Skip to content

Fix stress test with name deduping.#40692

Open
kvega005 wants to merge 1 commit into
microsoft:masterfrom
kvega005:user/kevinve/fix-volume-stress-test
Open

Fix stress test with name deduping.#40692
kvega005 wants to merge 1 commit into
microsoft:masterfrom
kvega005:user/kevinve/fix-volume-stress-test

Conversation

@kvega005
Copy link
Copy Markdown
Contributor

@kvega005 kvega005 commented Jun 2, 2026

Summary of the Pull Request

Fixes flakiness in WSLCTests::NamedVolumesStress where the post-stress invariant (InspectVolume returns WSLC_E_VOLUME_NOT_FOUND after all threads end on a Delete) intermittently failed because the WSLC volume cache drifted out of sync with docker. Root cause: docker's POST /volumes/create is idempotent. When a matching volume already exists it returns 201 but emits no create event, which left ghost entries permanently stuck at the front of our m_expectedEvents FIFO, causing later real events to be silently absorbed against the wrong slot. Fix: stop enqueueing self-initiated Create operations; only Destroy operations are tracked. 404s from InspectVolume (late-create-after-delete race) are now suppressed silently instead of logged.

PR Checklist

  • Closes: Link to issue #xxx
  • Communication: I've discussed this with core contributors already. If work hasn't been agreed, this work might be rejected
  • Tests: Added/updated if needed and all pass
  • Localization: All end user facing strings can be localized
  • Dev docs: Added/updated if needed
  • Documentation updated: If checked, please file a pull request on our docs repo and link it here: #xxx

Detailed Description of the Pull Request / Additional comments

Validation Steps Performed

Copilot AI review requested due to automatic review settings June 2, 2026 21:30
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR addresses flakiness in the WSLC named-volumes stress test by preventing the WSLC volume event “expected events” FIFO from getting permanently out of sync with Docker when Docker’s volume create is idempotent (and may not emit a corresponding create event). It also reduces noise from an expected race where a late create event arrives after a volume has already been deleted.

Changes:

  • Stop enqueueing self-initiated Create operations into m_expectedEvents (only Destroy remains tracked).
  • Suppress logging for InspectVolume 404 when opening a volume from an async create event race (late create after delete).

@kvega005 kvega005 marked this pull request as ready for review June 4, 2026 21:36
@kvega005 kvega005 requested a review from a team as a code owner June 4, 2026 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants