Fix stress test with name deduping.#40692
Open
kvega005 wants to merge 1 commit into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses flakiness in the WSLC named-volumes stress test by preventing the WSLC volume event “expected events” FIFO from getting permanently out of sync with Docker when Docker’s volume create is idempotent (and may not emit a corresponding create event). It also reduces noise from an expected race where a late create event arrives after a volume has already been deleted.
Changes:
- Stop enqueueing self-initiated Create operations into
m_expectedEvents(only Destroy remains tracked). - Suppress logging for
InspectVolume404 when opening a volume from an async create event race (late create after delete).
OneBlue
approved these changes
Jun 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
Fixes flakiness in
WSLCTests::NamedVolumesStresswhere the post-stress invariant (InspectVolumereturnsWSLC_E_VOLUME_NOT_FOUNDafter all threads end on aDelete) intermittently failed because the WSLC volume cache drifted out of sync with docker. Root cause: docker'sPOST /volumes/createis idempotent. When a matching volume already exists it returns 201 but emits no create event, which left ghost entries permanently stuck at the front of ourm_expectedEventsFIFO, causing later real events to be silently absorbed against the wrong slot. Fix: stop enqueueing self-initiated Create operations; only Destroy operations are tracked. 404s fromInspectVolume(late-create-after-delete race) are now suppressed silently instead of logged.PR Checklist
Detailed Description of the Pull Request / Additional comments
Validation Steps Performed