Skip to content

Use machine_type under vsrx device attribute instead of libvirt template #3411

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ipspace merged 2 commits into from
May 19, 2026
Merged

Use machine_type under vsrx device attribute instead of libvirt template #3411

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
482380e
Use machine_type under vsrx device attribute instead of libvirt template
sdargoeuves May 18, 2026
61f8c63
edit input/output after adding libvirt.machine_type for vsrx
sdargoeuves May 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions netsim/devices/vsrx.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,8 @@ virtualbox:
image: juniper/vsrx3
libvirt:
image: juniper/vsrx3
node:
machine_type: pc-i440fx-6.2
build: https://netlab.tools/labs/vsrx/
create_iso: vsrx
create:
Expand Down
1 change: 0 additions & 1 deletion netsim/templates/provider/libvirt/vsrx-domain.j2
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@
domain.cpus = 2
domain.memory = 4096
domain.disk_bus = "ide"
domain.machine_type = "pc-i440fx-6.2"
{% if "amd" in defaults.processor|lower %}
domain.cpu_mode = "custom"
{% endif %}
Expand Down
2 changes: 2 additions & 0 deletions tests/topology/expected/dual-stack.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -339,6 +339,8 @@ nodes:
ipv6: 2001:db8:1::4/64
node: a_eos
type: lan
libvirt:
machine_type: pc-i440fx-6.2
loopback:
ifindex: 0
ifname: lo0.0
Expand Down
2 changes: 2 additions & 0 deletions tests/topology/expected/isis-feature-test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -891,6 +891,8 @@ nodes:
net: 49.0002.0000.0000.0004.00
system_id: 0000.0000.0004
type: level-2
libvirt:
machine_type: pc-i440fx-6.2
loopback:
ifindex: 0
ifname: lo0.0
Expand Down
3 changes: 3 additions & 0 deletions tests/topology/expected/ospf.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -813,6 +813,9 @@ nodes:
node: a_eos
role: external
type: lan
libvirt:
_removed_attr:
- machine_type
loopback:
ifindex: 0
ifname: lo0.0
Expand Down
2 changes: 2 additions & 0 deletions tests/topology/expected/unnumbered.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -267,6 +267,8 @@ nodes:
node: c_nxos
role: core
type: p2p
libvirt:
machine_type: pc-i440fx-6.2
loopback:
ifindex: 0
ifname: lo0.0
Expand Down
1 change: 1 addition & 0 deletions tests/topology/input/ospf.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@ nodes:
device: eos
- name: j_vsrx
device: vsrx
libvirt.machine_type: false

links:
- c_nxos:
Expand Down