Use machine_type under vsrx device attribute instead of libvirt template#3411
Merged
Conversation
sdargoeuves
force-pushed
the
vsrx_use_machine_type
branch
from
497ca1e to
61f8c63
Compare
Collaborator
Author
|
Hopefully this doesn't fall into the new classic: "AI changed the tests to fit the (bad) code it created", because I didn't use AI to edit those tests! More seriously, I am not sure what's the right approach when it comes to testing. There were 4 topology containing |
ipspace
approved these changes
May 19, 2026
Owner
ipspace
left a comment
ipspace
left a comment
There was a problem hiding this comment.
Looks great to me. Thank you! Now I have to change the box-building process to use device machine_type if defined.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#3406 (review)
I didn't understand why it wouldn't work, until I've realised I needed to have it under
nodeinsidelibvirt