Skip to content

Update icon regen script to leverage git changes instead of bruteforce-regenerating all icons on every run #134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pkirkovsky wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Update icon regen script to leverage git changes instead of bruteforce-regenerating all icons on every run #134

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
bddc627
Use git to detect changed icons, don't regen all
pkirkovsky Aug 25, 2023
a7e36d9
Have script only look into the IssuerIcons dir
pkirkovsky Aug 26, 2023
a1002e5
Update GenerateIssuerIconAssets.sh
pkirkovsky Aug 29, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion GenerateIssuerIconAssets.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,8 +34,9 @@ write_json() {
EOF
}


Comment thread
pkirkovsky marked this conversation as resolved.
Outdated
cd "$(dirname "$0")"
for file in ./IssuerIcons/*.png; do
for file in "$(git ls-files --others --exclude-standard ./IssuerIcons)"; do
name="$(get_name $file)"
echo "Generating icon for ${name}"
imageset="./Tofu/Assets.xcassets/${name}.imageset/"
Expand Down