Update icon regen script to leverage git changes instead of bruteforce-regenerating all icons on every run#134
Open
pkirkovsky wants to merge 3 commits into
Open
Conversation
pkirkovsky
changed the title
ThinkChaos
approved these changes
Aug 29, 2023
whitespace cleanup Co-authored-by: ThinkChaos <ThinkChaos@users.noreply.github.com>
ThinkChaos
approved these changes
Aug 30, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of
for file in ./IssuerIcons/*.pngwe can usegit ls-files --others --exclude-standardto give us a list of untracked files in the current branch so we can operate only on those files.The workflow largely remains the same, except now icon contributors will have much smaller commits :)