Conversation
Conventional Commits Report
🚀 Conventional commits found. |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #185 +/- ##
==========================================
+ Coverage 20.17% 20.65% +0.48%
==========================================
Files 64 71 +7
Lines 2701 2943 +242
==========================================
+ Hits 545 608 +63
- Misses 2109 2282 +173
- Partials 47 53 +6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
1 task
mgoetzegb
force-pushed
the
VTI-alert-preparation
branch
from
827216a to
527a596
Compare
llugin
reviewed
Feb 5, 2026
llugin
reviewed
Feb 5, 2026
mgoetzegb
commented
Feb 5, 2026
Member
Author
mgoetzegb
left a comment
mgoetzegb
left a comment
There was a problem hiding this comment.
addressed all comments
llugin
previously approved these changes
Feb 5, 2026
efernasier
reviewed
Feb 6, 2026
efernasier
reviewed
Feb 6, 2026
efernasier
reviewed
Feb 6, 2026
efernasier
reviewed
Feb 6, 2026
mgoetzegb
added a commit
to greenbone/opensight-golang-libraries
that referenced
this pull request
Feb 6, 2026
… and `OriginResourceID` (#284) In the notification rules we want filter/match by a class of notification. But we also want to be able to pinpoint to a specific event instance in the notification (center). So far we had this information combined in the OriginUri, but it is more structured if we have to separate fields rather than needing to split up the value of OriginUri. ## References VTI-785 Adjustment in Notification Service: greenbone/opensight-notification-service#185
mgoetzegb
commented
Feb 6, 2026
Member
Author
mgoetzegb
left a comment
mgoetzegb
left a comment
There was a problem hiding this comment.
I addressed all the comments.
In the course of the review changes I realized that the naming was not good. namespace is not really a namespace, as we expect the origin class by itself to be globally unique. The property only exists for easier grouping and replacement of the origins.
Therefore I renamed namespace to serviceID (aa68b1e) and enforce uniqueness on database levels (3b15aca), so that there is immediate feedback for the caller.
efernasier
force-pushed
the
VTI-alert-preparation
branch
from
3b15aca to
87be8e3
Compare
efernasier
previously approved these changes
Feb 9, 2026
mgoetzegb
force-pushed
the
VTI-alert-preparation
branch
from
87be8e3 to
5afbada
Compare
mgoetzegb
commented
Feb 10, 2026
Member
Author
mgoetzegb
left a comment
mgoetzegb
left a comment
There was a problem hiding this comment.
thanks for the review 👍, added all requested changes
mgoetzegb
force-pushed
the
VTI-alert-preparation
branch
from
2743277 to
1b0b89d
Compare
mgoetzegb
force-pushed
the
VTI-alert-preparation
branch
from
1b0b89d to
f07f591
Compare
Member
Author
|
fixed conflicts with recently merged branch |
alex-heine
approved these changes
Feb 11, 2026
stefanTolksdorf
approved these changes
Feb 11, 2026
mgoetzegb
force-pushed
the
VTI-alert-preparation
branch
from
f07f591 to
03672d3
Compare
mgoetzegb
added a commit
to greenbone/opensight-golang-libraries
that referenced
this pull request
Feb 16, 2026
Allow conveniently calling the newly added endpoint (greenbone/opensight-notification-service#185). Each service using the notification service is supposed to register its used (classes of) origins once on service startup. ## References VTI-785
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Add register Origins endpoint, also split property
originUriintooriginClassandoriginResourceIDIn the future every notification sent to the notification service must have the property
originClassset. This property will be used for the alert rules, where a notification from a specific origin (class) and level (info, warning,...) is forwarded to e.g. a mattermost channel.Note: For now
originClassremains optional, to give client time to adjust, it will be made mandatory at a later point of time. Therefore this is not a breaking change so far. The effect of not settingoriginClassis that no rule will match such a notification (which is not yet implemented anyways so far).Why
Preparation for the alert feature.
References
VTI-785
Related Client change: greenbone/opensight-golang-libraries#284
Checklist