Conversation
Conventional Commits Report
🚀 Conventional commits found. |
1 task
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #284 +/- ##
==========================================
+ Coverage 57.66% 57.67% +0.01%
==========================================
Files 69 69
Lines 3812 3813 +1
==========================================
+ Hits 2198 2199 +1
Misses 1433 1433
Partials 181 181
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
alex-heine
approved these changes
Feb 5, 2026
… and `OriginResourceID` Motivation: In the notification rules we want filter/match by a class of notification. But we also want to be able to pinpoint to a specific event instance in the notification (center). So far we had this information combined in the OriginUri, but it is more structured if we have to separate fields rather than needing to split up the value of OriginUri.
mgoetzegb
force-pushed
the
VTI-785-adjust-ns-client
branch
from
f6f0f2f to
86c186a
Compare
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Snapshot WarningsEnsure that dependencies are being submitted on PR branches and consider enabling retry-on-snapshot-warnings. See the documentation for more information and troubleshooting advice. Scanned FilesNone |
mgoetzegb
added a commit
to greenbone/opensight-notification-service
that referenced
this pull request
Feb 12, 2026
Add register Origins endpoint, also split property `originUri` into `originClass` and `originResourceID` In the future every notification sent to the notification service must have the property `originClass` set. This property will be used for the alert rules, where a notification from a specific origin (class) and level (info, warning,...) is forwarded to e.g. a mattermost channel. Note: For now `originClass` remains optional, to give client time to adjust, it will be made mandatory at a later point of time. Therefore this is not a breaking change so far. The effect of not setting `originClass` is that no rule will match such a notification (which is not yet implemented anyways so far). ## Why Preparation for the alert feature. ## References VTI-785 Related Client change: greenbone/opensight-golang-libraries#284
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
change: notifications - split property
OriginUriintoOriginClassandOriginResourceIDWhy
In the notification rules we want filter/match by a class of notification. But we also want to be able to pinpoint to a specific event instance in the notification (center). So far we had this information combined in the OriginUri, but it is more structured if we have to separate fields rather than needing to split up the value of OriginUri.
References
VTI-785
Adjustment in Notification Service: greenbone/opensight-notification-service#185
Checklist