[core] Doc fixes related to mapping callback management.#9512
Open
jimblandy wants to merge 1 commit intogfx-rs:trunkfrom
Open
[core] Doc fixes related to mapping callback management.#9512jimblandy wants to merge 1 commit intogfx-rs:trunkfrom
jimblandy wants to merge 1 commit intogfx-rs:trunkfrom
Conversation
Add a few comments to tricky corners involved in ensuring that mapping callbacks are always invoked, never dropped.
andyleiserson
approved these changes
May 7, 2026
Comment on lines
+447
to
+450
| /// to the same buffer. The cycle is intentional — it keeps the buffer alive | ||
| /// while it sits in `LifetimeTracker::ready_to_map` with no other owner — | ||
| /// and is broken by `Buffer::map` when it moves the `BufferPendingMapping` | ||
| /// out of [`Buffer::map_state`]. |
Contributor
There was a problem hiding this comment.
Suggested change
| /// to the same buffer. The cycle is intentional — it keeps the buffer alive | |
| /// while it sits in `LifetimeTracker::ready_to_map` with no other owner — | |
| /// and is broken by `Buffer::map` when it moves the `BufferPendingMapping` | |
| /// out of [`Buffer::map_state`]. | |
| /// to the same buffer. The cycle is intentional, and is broken by | |
| /// `Buffer::map` when it moves the `BufferPendingMapping` out of | |
| /// [`Buffer::map_state`]. TODO: clarify the purpose of this |
As we discussed offline, I'm not sure this fully captures what's going on here, I think we should revisit it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a few comments to tricky corners involved in ensuring that mapping callbacks are always invoked, never dropped.