ref(alerts): remove dead standalone SystemAlerts mount#115222
Open
evanpurkhiser wants to merge 1 commit intomasterfrom
Open
ref(alerts): remove dead standalone SystemAlerts mount#115222evanpurkhiser wants to merge 1 commit intomasterfrom
evanpurkhiser wants to merge 1 commit intomasterfrom
Conversation
The standalone <SystemAlerts> mount at #blk_alerts has been dead plumbing
since at least 2015. No code path — Django template, plugin, or otherwise —
ever pushed alerts that surfaced via this mount; all AlertStore producers
live inside the SPA's <App> tree, which renders its own <SystemAlerts>.
Django flash messages render server-side via the {% if messages %} block
in this same template, never through React.
The corresponding frontend cleanup (removing SYSTEM_ALERTS from the init
queue) ships separately.
github-actions
Bot
added
the
Scope: Backend
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The standalone
<SystemAlerts>mount at#blk_alerts(rendered as a separate React tree on every page that extendslayout.html) has been dead plumbing since the React+Reflux era began in 2015.Verified across the full git history (
git log -SforAlertStore.addAlert,AlertActions.addAlert,addAlertin*.html,SentryApp.AlertStore,Sentry.AlertActions, etc.) — no Django template, plugin, or external code has ever pushed alerts via this mount. EveryAlertStoreproducer lives inside the SPA's<App>tree, which renders its own<SystemAlerts>viaappBodyContent.tsx/organizationLayout/index.tsx. Django flash messages render server-side via the{% if messages %}block in this same template, never through React.The matching frontend cleanup (removing
SYSTEM_ALERTSfromprocessInitQueue'sCOMPONENT_MAPand theSentryInitRenderReactComponentenum, plus the corresponding test) ships as a separate PR per the frontend/backend split rule. Either PR can land first — the frontend gracefully skips unknown component names viaObject.hasOwn(COMPONENT_MAP, ...).The
<Indicators>standalone mount is intentionally preserved — it is genuinely live and needed by the Setup Wizard flow (a non-SPA page that callsaddErrorMessagefromwizardProjectSelection.tsx).