ref(alerts): drop SystemAlerts from the init queue component map#115223
Open
evanpurkhiser wants to merge 1 commit intomasterfrom
Open
ref(alerts): drop SystemAlerts from the init queue component map#115223evanpurkhiser wants to merge 1 commit intomasterfrom
evanpurkhiser wants to merge 1 commit intomasterfrom
Conversation
Backend partial/alerts.html no longer pushes a SystemAlerts renderReact config (see prior commit). Remove the matching frontend entry from COMPONENT_MAP, the SentryInitRenderReactComponent enum, and the corresponding test.
evanpurkhiser
requested review from
JonasBa,
billyvg and
markstory
and removed request for
a team
github-actions
Bot
added
the
Scope: Frontend
Contributor
📊 Type Coverage Diff✅ No new type safety issues introduced. Coverage: 93.46% |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Django template
partial/alerts.htmlno longer pushes aSystemAlertsrenderReactconfig ontowindow.__onSentryInit(see #115222). Drop the corresponding frontend entry fromprocessInitQueue'sCOMPONENT_MAP, theSentryInitRenderReactComponentenum, and the now-orphaned test.The standalone
<SystemAlerts>mount has been dead plumbing since the React/Reflux era began in 2015 — see the linked backend PR for the full history trek. EveryAlertStoreproducer lives inside the SPA's<App>tree, which renders its own<SystemAlerts>.SystemAlertsitself stays — only its registration in the init queue is removed. The component continues to be mounted in-tree byappBodyContent.tsxandorganizationLayout/index.tsx.