Skip to content

Move submodules to repo root. #926

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
polina-c merged 1 commit into from
May 18, 2026
Merged

Move submodules to repo root. #926

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .agent/skills/genui-helper/SKILL.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,9 +51,9 @@ When creating a new UI component in `genui`:
## References

- A2UI Specification
- Available in the submodule at @packages/genui/submodules/a2ui
- The specification documentation is available in @packages/genui/submodules/a2ui/specification/v0.9/docs
- The specification schemas are available in @packages/genui/submodules/a2ui/specification/v0.9/json
- Available in the submodule at @submodules/a2ui
- The specification documentation is available in @submodules/a2ui/specification/v0.9/docs
- The specification schemas are available in @submodules/a2ui/specification/v0.9/json
- Because it is a submodule, you may need to update the submodule to get the latest specification.
- To find out details of a specific dart compiler diagnostic message, use the following url format to look up the details:
- https://dart.dev/tools/diagnostics/<message_id>
Expand Down
6 changes: 3 additions & 3 deletions .gitmodules
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
[submodule "packages/json_schema_builder/submodules/JSON-Schema-Test-Suite"]
path = packages/json_schema_builder/submodules/JSON-Schema-Test-Suite
[submodule "JSON-Schema-Test-Suite"]
path = submodules/JSON-Schema-Test-Suite
url = https://github.com/json-schema-org/JSON-Schema-Test-Suite.git
[submodule "a2ui"]
path = packages/genui/submodules/a2ui
path = submodules/a2ui
url = https://github.com/google/A2UI.git
branch = main
2 changes: 1 addition & 1 deletion analysis_options.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ include: package:lints/recommended.yaml

analyzer:
exclude:
- 'packages/genui/submodules/**'
- 'submodules/**'
language:
strict-casts: true
strict-inference: true
Expand Down
6 changes: 4 additions & 2 deletions packages/json_schema_builder/test/test_suite_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,9 +12,11 @@ import 'package:test/test.dart';

void main() {
final testSuiteDir = Directory(
'submodules/JSON-Schema-Test-Suite/tests/draft2020-12',
'../../submodules/JSON-Schema-Test-Suite/tests/draft2020-12',
);
final remoteDir = Directory(
'../../submodules/JSON-Schema-Test-Suite/remotes',
);
Comment on lines 14 to 19
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot May 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The base path for the submodule is duplicated across multiple Directory initializations. Centralizing this path in a variable improves maintainability and makes it easier to update if the repository structure changes again in the future.

Suggested change
final testSuiteDir = Directory(
'submodules/JSON-Schema-Test-Suite/tests/draft2020-12',
'../../submodules/JSON-Schema-Test-Suite/tests/draft2020-12',
);
final remoteDir = Directory(
'../../submodules/JSON-Schema-Test-Suite/remotes',
);
const testSuiteBase = '../../submodules/JSON-Schema-Test-Suite';
final testSuiteDir = Directory('$testSuiteBase/tests/draft2020-12');
final remoteDir = Directory('$testSuiteBase/remotes');

final remoteDir = Directory('submodules/JSON-Schema-Test-Suite/remotes');

// Optional tests are not required to pass for full compliance.
final optionalTestSuiteDir = Directory('${testSuiteDir.path}/optional');
Expand Down
0 ...builder/submodules/JSON-Schema-Test-Suite → submodules/JSON-Schema-Test-Suite
Open in desktop
Submodule JSON-Schema-Test-Suite updated from 000000 to 15e450
0 packages/genui/submodules/a2ui → submodules/a2ui
Open in desktop
Submodule a2ui updated from 000000 to 39a26c
Loading