Skip to content

Move submodules to repo root.#926

Merged
polina-c merged 1 commit into
flutter:mainfrom
polina-c:move-submodules
May 18, 2026
Merged

Move submodules to repo root.#926
polina-c merged 1 commit into
flutter:mainfrom
polina-c:move-submodules

Conversation

@polina-c
Copy link
Copy Markdown
Collaborator

@polina-c polina-c commented May 16, 2026

Contributes to google/A2UI#1383.

Prerequisite for #917

Fix the issue wuth submodules by moving them to root.

ISSUE:

flutter pub publish gives a warning that gitignored files are committed.

Pub's gitignore validator reports submodules/a2ui as ignored even though no .gitignore rule actually matches it — git check-ignore returns nothing locally. So pub uses its own logic for this, not real git ignore semantics, and it appears to treat an uninitialized submodule gitlink as "ignored."

Relocates the a2ui and JSON-Schema-Test-Suite git submodules from
inside packages/ to a top-level submodules/ directory so they are
not part of any pub package's source tree. This unblocks
pub publish --dry-run for genui and json_schema_builder, which was
flagging the submodule gitlinks as 'tracked but ignored'.

- packages/genui/submodules/a2ui -> submodules/a2ui
- packages/json_schema_builder/submodules/JSON-Schema-Test-Suite ->
  submodules/JSON-Schema-Test-Suite

Updates:
- .gitmodules paths
- analysis_options.yaml exclude pattern
- json_schema_builder test fixture paths (now ../../submodules/...)
- .agent/skills/genui-helper/SKILL.md references
gemini-code-assist[bot]

This comment was marked as outdated.

@polina-c polina-c mentioned this pull request May 16, 2026
Copy link
Copy Markdown
Collaborator

@andrewkolos andrewkolos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM, though people with existing checkouts will probably have to resync submodules to avoid orphaned files (and broken tests if i had to guess)

edit: this should do the job:

git submodule update --init --recursive

@polina-c polina-c merged commit baff6dc into flutter:main May 18, 2026
25 checks passed
@polina-c polina-c deleted the move-submodules branch May 18, 2026 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants