Skip to content

refactor(core): standardize error logging for enhanced robustness #853

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
RinZ27 wants to merge 2 commits into
base: main
Choose a base branch
from
Open

refactor(core): standardize error logging for enhanced robustness #853

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8e4556a
Standardize error logging to prevent injection risks
RinZ27 Mar 21, 2026
ef54f82
Merge branch 'main' into fix/log-injection-robustness
jrriehl Apr 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 10 additions & 7 deletions python/uagents-core/uagents_core/utils/messages.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,8 +127,9 @@ def record_agent_interaction(
response.raise_for_status()
except requests.RequestException as e:
logger.error(
"Failed to track interaction",
extra={"error": str(e), "interaction": interaction},
"Failed to track interaction: %s",
e,
extra={"interaction": interaction},
)


Expand Down Expand Up @@ -265,11 +266,12 @@ def send_message_to_agent(
except requests.RequestException as e:
if isinstance(e, requests.HTTPError):
logger.error(
f"Failed to send message to agent, returned HTTP error {e.response.status_code}",
extra={"error": str(e)},
"Failed to send message to agent, returned HTTP error %s: %s",
e.response.status_code,
e,
)
else:
logger.error("Failed to send message to agent", extra={"error": str(e)})
logger.error("Failed to send message to agent: %s", e)
status_result.append(
MsgStatus(
status=DeliveryStatus.FAILED,
Expand All @@ -285,8 +287,9 @@ def send_message_to_agent(
return parse_envelope_raw(response.text, response_type)
except ValidationError as e:
logger.error(
"Received invalid response envelope",
extra={"error": str(e), "response": response.text},
"Received invalid response envelope: %s",
e,
extra={"response": response.text},
)

return status_result
Loading