refactor(core): standardize error logging for enhanced robustness#853
Open
RinZ27 wants to merge 2 commits into
Open
refactor(core): standardize error logging for enhanced robustness#853RinZ27 wants to merge 2 commits into
RinZ27 wants to merge 2 commits into
Conversation
RinZ27
changed the title
jrriehl
requested review from
Alejandro-Morales,
Archento,
jrriehl,
lrahmani and
qati
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Standardizing error logging within the
messages.pymodule to enhance robustness against potential log injection and spoofing risks. The current implementation often passes raw exception strings directly into the logger'sextracontext or uses f-strings for error messages. In a decentralized agent environment where exception data might originate from untrusted remote endpoints, this practice can lead to misleading or malformed logs.By transitioning to parameterized logging, external data is handled safely by the logging framework. This adjustment improves the overall reliability of the agent's telemetry without affecting existing message-handling logic.
Linked Issues
None
Types of changes
Checklist
Further comments
Parameterized logging is a standard practice to ensure telemetry integrity, especially when dealing with data derived from external network exceptions.