Skip to content

[Nexthop][fboss2-dev] Add IPv4/IPv6 default-route tests for the static route add CLI #1383

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
hillol-nexthop wants to merge 1 commit into from
Closed

[Nexthop][fboss2-dev] Add IPv4/IPv6 default-route tests for the static route add CLI #1383

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 36 additions & 0 deletions fboss/cli/fboss2/test/config/CmdConfigIpRouteTest.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -225,6 +225,24 @@ TEST_F(CmdConfigIpRouteTestFixture, dropWithExtraNexthops) {
std::invalid_argument);
}

// Test adding IPv4 default route (0.0.0.0/0)
TEST_F(CmdConfigIpRouteTestFixture, addIpv4DefaultRoute) {
auto cmd = CmdConfigProtocolStaticIpRouteAdd();
StaticRouteAddIpArg routeArg({"0.0.0.0/0", "192.168.1.1"});

auto result = cmd.queryClient(localhost(), routeArg);

EXPECT_THAT(result, HasSubstr("Successfully added static route"));
EXPECT_THAT(result, HasSubstr("0.0.0.0/0"));

auto& nhopRoutes = *ConfigSession::getInstance()
.getAgentConfig()
.sw()
->staticRoutesWithNhops();
ASSERT_EQ(nhopRoutes.size(), 1);
EXPECT_EQ(*nhopRoutes[0].prefix(), "0.0.0.0/0");
}

// ============== IPv4 Route Delete Tests ==============

// Test deleting an existing route with nexthops
Expand Down Expand Up @@ -389,6 +407,24 @@ TEST_F(CmdConfigIpRouteTestFixture, ipv4NexthopInIpv6Command) {
std::invalid_argument);
}

// Test adding IPv6 default route (::/0)
TEST_F(CmdConfigIpRouteTestFixture, addIpv6DefaultRoute) {
auto cmd = CmdConfigProtocolStaticIpv6RouteAdd();
StaticRouteAddIpv6Arg routeArg({"::/0", "2001:db8::1"});

auto result = cmd.queryClient(localhost(), routeArg);

EXPECT_THAT(result, HasSubstr("Successfully added static route"));
EXPECT_THAT(result, HasSubstr("::/0"));

auto& nhopRoutes = *ConfigSession::getInstance()
.getAgentConfig()
.sw()
->staticRoutesWithNhops();
ASSERT_EQ(nhopRoutes.size(), 1);
EXPECT_EQ(*nhopRoutes[0].prefix(), "::/0");
}

// ============== IPv6 Route Delete Tests ==============

// Test deleting an existing IPv6 route with nexthops
Expand Down
Loading