[Nexthop][fboss2-dev] Add IPv4/IPv6 default-route tests for the static route add CLI#1383
Closed
hillol-nexthop wants to merge 1 commit into
Closed
[Nexthop][fboss2-dev] Add IPv4/IPv6 default-route tests for the static route add CLI#1383hillol-nexthop wants to merge 1 commit into
hillol-nexthop wants to merge 1 commit into
Conversation
PR facebook#1118 added CLI commands for interface IP addresses and static routes. Two tests written during review of the original change never made it into the upstream branch: addIpv4DefaultRoute (0.0.0.0/0) and addIpv6DefaultRoute (::/0). Add them to CmdConfigIpRouteTest.cpp to close the coverage gap for adding default routes via `config protocol static route add`.
Contributor
|
@joseph5wu has imported this pull request. If you are a Meta employee, you can view this in D112388254. |
Contributor
|
@joseph5wu merged this pull request in b98f7e7. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
#1118 added CLI commands for interface IP addresses and static routes. Two tests written during review of the original change never made it into the branch that landed:
addIpv4DefaultRoute(0.0.0.0/0) andaddIpv6DefaultRoute(::/0).This adds them to
CmdConfigIpRouteTest.cpp, closing the coverage gap for adding default routes viaconfig protocol static route add:0.0.0.0/0) with a nexthop::/0) with a nexthopBoth assert the command reports success and that the route lands in
staticRoutesWithNhopswith the expected prefix.Test Plan
Test-only change. The two tests follow the exact structure of the neighboring tests in the same fixture (fresh per-test config, same assertion patterns) and pass in our CI.