Skip to content

feat: (manager) -> support existingConfigSecret for external config manager #500

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
junjieteo wants to merge 3 commits into
base: main
Choose a base branch
from
Open

feat: (manager) -> support existingConfigSecret for external config manager #500

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d5013b6
feat(manager): support existingConfigSecret for external config manag…
junjieteo Apr 30, 2026
e4d6626
BUmp the chart version
junjieteo Apr 30, 2026
8475007
docs: regenerate README.md with helm-docs
junjieteo May 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions charts/dragonfly/Chart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ name: dragonfly
description: Dragonfly is an intelligent P2P based image and file distribution system
icon: https://raw.githubusercontent.com/dragonflyoss/dragonfly/main/docs/images/logo/dragonfly.svg
type: application
version: 1.6.23
version: 1.6.24
appVersion: 2.4.4-rc.1
keywords:
- dragonfly
Expand All @@ -27,9 +27,7 @@ sources:

annotations:
artifacthub.io/changes: |
- Bump dragonfly version to v2.4.4-rc.1.
- Bump client version to v1.3.6.
- Add proxyAllRegistries configuration to support containerd to pull images.
- Add manager.existingConfigSecret option to mount external Secret for config.

artifacthub.io/links: |
- name: Chart Source
Expand Down
1 change: 1 addition & 0 deletions charts/dragonfly/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -336,6 +336,7 @@ helm delete dragonfly --namespace dragonfly-system
| manager.config.tracing.protocol | string | `"grpc"` | Protocol specifies the communication protocol for the tracing server. Supported values: "http", "https", "grpc" (default: None). This determines how tracing logs are transmitted to the server. |
| manager.deploymentAnnotations | object | `{}` | Deployment annotations. |
| manager.enable | bool | `true` | Enable manager. |
| manager.existingConfigSecret | string | `""` | Name of an existing Secret containing the full manager.yaml config. When set, the chart will NOT generate a ConfigMap and will mount this Secret at /etc/dragonfly instead. The Secret must have a key named "manager.yaml" containing the complete configuration. This allows you to manage the entire config externally (e.g., via External Secrets Operator, Sealed Secrets, or manual creation). |
| manager.extraEnvVars | list | `[]` | Extra environment variables for pod. |
| manager.extraVolumeMounts | list | `[{"mountPath":"/var/log/dragonfly/manager","name":"logs"}]` | Extra volumeMounts for manager. |
| manager.extraVolumes | list | `[{"emptyDir":{},"name":"logs"}]` | Extra volumes for manager. |
Expand Down
2 changes: 2 additions & 0 deletions charts/dragonfly/templates/manager/manager-configmap.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
{{- if .Values.manager.enable }}
{{- if not .Values.manager.existingConfigSecret }}
apiVersion: v1
kind: ConfigMap
metadata:
Expand Down Expand Up @@ -88,3 +89,4 @@ data:
tracing:
{{ toYaml .Values.manager.config.tracing | indent 6 }}
{{- end }}
{{- end }}
10 changes: 10 additions & 0 deletions charts/dragonfly/templates/manager/manager-deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,9 @@ spec:
{{ toYaml .Values.manager.podLabels | indent 8 }}
{{- end }}
annotations:
{{- if not .Values.manager.existingConfigSecret }}
checksum/config: {{ include (print $.Template.BasePath "/manager/manager-configmap.yaml") . | sha256sum }}
{{- end }}
{{- if .Values.manager.podAnnotations }}
{{ toYaml .Values.manager.podAnnotations | indent 8 }}
{{- end }}
Expand Down Expand Up @@ -130,11 +132,19 @@ spec:
failureThreshold: 5
volumes:
- name: config
{{- if .Values.manager.existingConfigSecret }}
secret:
secretName: {{ .Values.manager.existingConfigSecret }}
items:
- key: manager.yaml
path: manager.yaml
Comment thread
junjieteo marked this conversation as resolved.
{{- else }}
configMap:
name: {{ template "dragonfly.manager.fullname" . }}
items:
- key: manager.yaml
path: manager.yaml
{{- end }}
{{- if .Values.manager.extraVolumes }}
{{- toYaml .Values.manager.extraVolumes | nindent 6 }}
{{- end }}
Expand Down
7 changes: 7 additions & 0 deletions charts/dragonfly/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,6 +78,13 @@ manager:
deploymentAnnotations: {}
# -- Extra environment variables for pod.
extraEnvVars: []
# -- Name of an existing Secret containing the full manager.yaml config.
# When set, the chart will NOT generate a ConfigMap and will mount this
# Secret at /etc/dragonfly instead. The Secret must have a key named
# "manager.yaml" containing the complete configuration.
# This allows you to manage the entire config externally (e.g., via
# External Secrets Operator, Sealed Secrets, or manual creation).
Comment thread
junjieteo marked this conversation as resolved.
existingConfigSecret: ""
# -- Extra volumes for manager.
extraVolumes:
- name: logs
Expand Down
Loading