feat: (manager) -> support existingConfigSecret for external config manager#500
feat: (manager) -> support existingConfigSecret for external config manager#500junjieteo wants to merge 3 commits into
Conversation
junjieteo
force-pushed
the
feat/add-postgres-config
branch
from
4c0371a to
2cf5a1d
Compare
…ement Allow users to provide a pre-existing Secret containing the full manager.yaml config instead of using the chart-generated ConfigMap. Enables integration with External Secrets Operator, Sealed Secrets, and other secret management solutions. Signed-off-by: Teo Jun Jie <jun.teo@avant.com>
Signed-off-by: Teo Jun Jie <jun.teo@avant.com>
Signed-off-by: Teo Jun Jie <jun.teo@avant.com>
junjieteo
force-pushed
the
feat/add-postgres-config
branch
from
2cf5a1d to
8475007
Compare
There was a problem hiding this comment.
Pull request overview
This PR adds Helm chart support for sourcing the manager configuration from a pre-existing Kubernetes Secret instead of the chart-generated ConfigMap. In the Dragonfly chart, that fits the existing pattern of templating manager deployment resources from values.yaml, while attempting to let operators externalize config management.
Changes:
- Added a new
manager.existingConfigSecretvalue and documented it in chart values/README. - Made manager ConfigMap creation conditional so it is skipped when an external Secret is supplied.
- Switched the manager Deployment’s
configvolume between ConfigMap and Secret, and skipped the config checksum annotation for the Secret path.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
charts/dragonfly/values.yaml |
Adds the new manager value and inline docs for external Secret-based config. |
charts/dragonfly/templates/manager/manager-deployment.yaml |
Conditionally mounts manager config from either Secret or ConfigMap and adjusts pod annotations. |
charts/dragonfly/templates/manager/manager-configmap.yaml |
Skips rendering the generated manager ConfigMap when an external Secret is configured. |
charts/dragonfly/README.md |
Updates generated chart docs for the new value. |
charts/dragonfly/Chart.yaml |
Bumps chart version and release notes metadata for the feature. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
junjieteo
force-pushed
the
feat/add-postgres-config
branch
from
1aa0382 to
8475007
Compare
|
@gaius-qi @imeoer @chlins @CormickKneey may i get a review for this? |
|
@junjieteo Thanks for the contribution! However, I don't think this is a generally needed feature. The standard approach in this chart is to configure the manager via values.yaml, which then renders the ConfigMap accordingly. This covers the vast majority of use cases. |
Description
This PR adds a new
manager.existingConfigSecretoption that allows users to mount a pre-existing Kubernetes Secret containing the completemanager.yamlconfiguration, instead of using the chart-generated ConfigMap.Changes
values.yamlmanager.existingConfigSecretoption (default: empty string)manager-configmap.yamlexistingConfigSecretis not setmanager-deployment.yamlUsage