fix(query): trim numeric and boolean string casts#19809
Open
KKould wants to merge 1 commit intodatabendlabs:mainfrom
Open
fix(query): trim numeric and boolean string casts#19809KKould wants to merge 1 commit intodatabendlabs:mainfrom
KKould wants to merge 1 commit intodatabendlabs:mainfrom
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 0878089d52
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
0878089 to
9e33e8a
Compare
846442d to
95d554a
Compare
11 tasks
95d554a to
3bf7902
Compare
3bf7902 to
104ee1d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/
Summary
CAST(' 1e1' AS DOUBLE)andCAST(' 1e1' AS INTEGER)succeed consistently.'1'/'0'in addition to'true'/'false'.tests/sqllogictests/suites/query/functions/02_0002_function_cast.test.Tests
target/debug/databend-sqllogictests --run 'tests/sqllogictests/suites/query/functions/02_0002_function_cast.test' --handlers httptarget/debug/databend-sqllogictests --run 'tests/sqllogictests/suites/query/functions/02_0002_function_cast.test' --handlers mysql --port 3307UPDATE_GOLDENFILES=1 cargo test -p databend-common-functions --test it scalars::cast::test_cast -- --exactcargo test -p databend-common-functions --test it scalars::cast::test_cast -- --exacttarget/debug/databend-sqllogictests --run 'tests/sqllogictests/suites/duckdb/sql/cast/test_exponent_in_cast.test' --handlers httpType of change
This change is