Replace Apex charts with Apache eCharts - #2544
Conversation
fa52454 to
8b25f05
Compare
eb6bd53 to
898d313
Compare
# Conflicts: # package.json # yarn.lock
72dc319 to
f2d80c1
Compare
samuel-denton
left a comment
There was a problem hiding this comment.
I'm happy to approve this as is, the previous functionality has been replicated and the charts look good.
There are a few small outstanding issues that could be improved but they were present before this PR. Mostly related to letting a user know why there is nothing showing (No data, workflow not run, no task selected etc).
There are some style improvements that can be addressed in a follow up PR at some point, like the timeline on the time-series looked a bit nicer before, but functionality wise I think its good.
I think this was caused by a slightly obscure bug, if you open the Gantt view while the window is very narrow, then maximise it again, the chart remains squished. I think this is unlikely to come up in practice, but should be fixable if we want with an additional width re-calculation after a resize event. |
|
I'm going to action some of those points, as this is an easy place to do it. |



Apex Charts has changed it's licensing so we need to pivot to a different charting library.
Apache eCharts seems like a good fit for us. It uses the Apache 2.0 licence (https://www.apache.org/licenses/LICENSE-2.0.html).
This started of a play branch to see if it meets our requirements which has gone very well.
This PR closes #2256 and closes #2406
Check List
CONTRIBUTING.mdand added my name as a Code Contributor.setup.cfg(andconda-environment.ymlif present).?.?.xbranch.