upgrade apexcharts - #2419
Conversation
To reproduce: scroll with mouse wheel over the gantt view. The chart disappears entirely! |
|
Yep - #2256, frustrating. Guessing it's no worse than before? |
|
Not reproduced that before other than when apexcharts is upgraded. Edit: reproduced on master by deliberately zooming in order to make the data go off the edges. But on this branch it's a lot worse as it happens on the slightest scroll |
|
This is probably going to serve as the blocker PR for all apexcharts upgrade.
|
|
Are we still looking to upgrade apex? |
|
We can upgrade to v4, but this panning issue would have to be resolved first. We cannot upgrade to v5 - ever! |
|
I'm really struggling to fix this. I can kind of fix the panning issue but zooming is just not playing ball. |
|
Apexcharts will not be updated. Instead a new library, Apache eCharts, will be used. |
Upgrade to the last good version of apexcharts.
The licence was still MIT @ 4.7.0: https://github.com/apexcharts/apexcharts.js/blob/v4.7.0/LICENSE
After which it went evil, hence #1978 cannot be merged.
@ChrisPaulBennett, please can you review this and make sure the upgrade hasn't broken anything, if changes are needed, push them to this branch. @MetRonnie noted panning issues (#1978 (comment)), although, having tested, I'm not sure panning works on master either?
Check List
CONTRIBUTING.mdand added my name as a Code Contributor.setup.cfg(andconda-environment.ymlif present).?.?.xbranch.