Skip to content

Fix external PRs failing #212

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
GAsplund wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Fix external PRs failing #212

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
0b5e3b0
Don't push image when external PR
GAsplund May 19, 2026
db7a46a
Change reporter and fail mode
GAsplund May 28, 2026
39190cb
Formatting
GAsplund May 28, 2026
9fae51c
Add deliberate issues
GAsplund May 28, 2026
d16cfeb
Run validation regardless of previous outcomes
GAsplund May 28, 2026
fcbb0ef
Resolve ESLint
GAsplund May 28, 2026
c888609
Resolve Prettier
GAsplund May 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions .github/workflows/code_validation.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ jobs:
- run: pnpm test

run-linters:
name: Execute linters
name: Linting
runs-on: ubuntu-latest

steps:
Expand All @@ -48,21 +48,25 @@ jobs:
- run: pnpm install prettier

- run: pnpm install --frozen-lockfile
id: install_dependencies

- name: ESLint
uses: reviewdog/action-eslint@v1
with:
github_token: ${{ secrets.GITHUB_TOKEN }}
reporter: github-pr-check
reporter: github-pr-annotations
filter_mode: ${{ (github.event_name == 'pull_request') && 'file' || 'nofilter' }}
fail_level: warning
level: ${{ (github.event_name == 'pull_request') && 'error' || 'warning' }}
tool_name: ESLint

- name: Prettier
if: ${{ !cancelled() && steps.install_dependencies.outcome == 'success' }}
uses: EPMatt/reviewdog-action-prettier@v1
with:
github_token: ${{ secrets.GITHUB_TOKEN }}
reporter: github-pr-check
reporter: github-pr-annotations
filter_mode: ${{ (github.event_name == 'pull_request') && 'file' || 'nofilter' }}
fail_level: warning
level: ${{ (github.event_name == 'pull_request') && 'error' || 'warning' }}
tool_name: Prettier
2 changes: 1 addition & 1 deletion .github/workflows/docker.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ jobs:
- name: Build Docker image (and push on main)
uses: docker/build-push-action@v6
with:
push: true
push: ${{ github.event_name != 'pull_request' || github.event.pull_request.head.repo.full_name == github.repository }}
tags: ${{ steps.meta.outputs.tags }}
labels: ${{ steps.meta.outputs.labels }}
cache-from: type=gha
Expand Down
Loading