Fix external PRs failing#212
Open
GAsplund wants to merge 7 commits into
Open
Conversation
Member
Author
|
It seems like things are working properly now, but the linting step is no longer as clear which step failed as you have to click into the job now. A worthy tradeoff imo. Once this is approved for merge, I will disable expected checks for ESLint and Prettier, and expect linting instead. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes a relatively simple fix that simply does not push images when a PR is opened from outside the main repository.
This currently does not resolve issues with expected linter runs.