Skip to content

[5.x] Variant field layout tabs displayed incorrectly #4336

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nfourtythree merged 2 commits into from
Jul 16, 2026
+17 −14
Merged

[5.x] Variant field layout tabs displayed incorrectly #4336

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
490bb6e
#4335 variant field layout tabs displayed incorrectly
nfourtythree Jul 16, 2026
a49d13b
Fix left over debug code
nfourtythree Jul 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
# Release Notes for Craft Commerce

## Unreleased

- Fixed a bug where product variant field layout tabs displayed incorrectly on variant slideouts. ([#4335](https://github.com/craftcms/commerce/issues/4335))

## 5.7.0 - 2026-07-16

### Store Management
Expand Down
28 changes: 14 additions & 14 deletions src/fieldlayoutelements/PurchasablePriceField.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,18 +129,19 @@ public function inputHtml(ElementInterface $element = null, bool $static = false
$toggleAttributes['data-init-prices'] = 'true';
$toggleContent = PurchasableHelper::catalogPricingRulesTableByPurchasableId($element->id, $element->storeId) .
Html::beginTag('div', ['class' => 'flex']) .
// New catalog price button
Html::button(Craft::t('commerce', 'Add catalog price'), [
'class' => 'btn icon add js-cpr-slideout',
'data-icon' => 'plus',
'data-store-id' => $element->storeId,
'data-store-handle' => $element->getStore()->handle,
'data-purchasable-id' => $element->id,
'data-asdsa' => $element->firstSave,
]) .
Cp::renderTemplate('commerce/prices/_status', [
'areCatalogPricingJobsRunning' => Plugin::getInstance()->getCatalogPricing()->areCatalogPricingJobsRunning(),
]);
// New catalog price button
Html::button(Craft::t('commerce', 'Add catalog price'), [
'class' => 'btn icon add js-cpr-slideout',
'data-icon' => 'plus',
'data-store-id' => $element->storeId,
'data-store-handle' => $element->getStore()->handle,
'data-purchasable-id' => $element->id,
'data-asdsa' => $element->firstSave,
]) .
Comment thread
Copilot marked this conversation as resolved.
Cp::renderTemplate('commerce/prices/_status', [
'areCatalogPricingJobsRunning' => Plugin::getInstance()->getCatalogPricing()->areCatalogPricingJobsRunning(),
]) .
Html::endTag('div');
} else {
/** @var Sale[] $relatedSales */
$relatedSales = Plugin::getInstance()->getSales()->getSalesRelatedToPurchasable($element);
Expand Down Expand Up @@ -204,8 +205,7 @@ public function inputHtml(ElementInterface $element = null, bool $static = false
Html::tag(
'div',
// Prices table
$toggleContent .
Html::endTag('div'),
$toggleContent,
[
'id' => 'purchasable-toggle',
'class' => 'hidden',
Expand Down
Loading