[5.x] Variant field layout tabs displayed incorrectly#4336
Merged
nfourtythree merged 2 commits intoJul 16, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes a Craft Commerce control panel UI issue where variant slide-out field layout tabs don’t switch correctly when the variant has related sales, by correcting HTML structure in the purchasable price field output.
Changes:
- Adjusted the generated markup in
PurchasablePriceFieldto ensure the price/sales toggle content is wrapped with properly balanced tags. - Added a changelog entry referencing issue #4335.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/fieldlayoutelements/PurchasablePriceField.php | Fixes HTML tag balancing/structure around the toggle content in the purchasable price field to prevent CP UI layout/tab issues. |
| CHANGELOG.md | Documents the fix in the Unreleased section with a link to the reported issue. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
nfourtythree
deleted the
nathaniel/com-591-5x-variant-slide-out-tabs-not-switching-when-variant-has-a
branch
July 16, 2026 15:31
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issues
#4335