fix: prefer actual delivery date over scheduled in UPStrack()#39
Draft
toddr-bot wants to merge 1 commit into
Draft
fix: prefer actual delivery date over scheduled in UPStrack()#39toddr-bot wants to merge 1 commit into
toddr-bot wants to merge 1 commit into
Conversation
When UPS returns both deliveredDate and scheduledDeliveryDate for a delivered package, the function now correctly returns the actual delivery date instead of the scheduled estimate. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Swap delivery date precedence so
deliveredDatewins overscheduledDeliveryDate.Why
When a package is delivered, UPS may return both dates. The old code preferred
scheduledDeliveryDate— meaning callers would see when the package was supposed to arrive, not when it actually did. For any delivered package with both fields, this returned the wrong date.How
One-line change:
$track->{deliveredDate} || $track->{scheduledDeliveryDate}instead of the reverse.Testing
Added a test with a response containing both dates, verifying
deliveredDatetakes precedence. Full test suite passes.🤖 Generated with Claude Code
Quality Report
Changes: 2 files changed, 27 insertions(+), 1 deletion(-)
Code scan: clean
Tests: passed (OK)
Branch hygiene: clean
Generated by Kōan post-mission quality pipeline