Skip to content

fix: prefer actual delivery date over scheduled in UPStrack() #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
toddr-bot wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

fix: prefer actual delivery date over scheduled in UPStrack() #39

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/Business/UPS.pm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,7 +119,7 @@ sub UPStrack {
$retValue{'Shipped To'} = join( ', ', @parts ) if @parts;
}

my $delivery_date = $track->{scheduledDeliveryDate} || $track->{deliveredDate};
my $delivery_date = $track->{deliveredDate} || $track->{scheduledDeliveryDate};
$retValue{'Delivery Date'} = $delivery_date if $delivery_date;
$retValue{'Signed By'} = $track->{receivedBy} if $track->{receivedBy};
$retValue{'Location'} = $track->{leftAt} if $track->{leftAt};
Expand Down
26 changes: 26 additions & 0 deletions t/upstrack.t
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -384,4 +384,30 @@ subtest 'UPStrack dies on undef tracking number' => sub {
like( $@, qr/tracking/i, 'dies on undef tracking number' );
};

# Response with BOTH scheduledDeliveryDate and deliveredDate
my $both_dates_json = <<'JSON';
{
"trackDetails": [
{
"trackingNumber": "1Z999AA10123456784",
"packageStatus": "Delivered",
"scheduledDeliveryDate": "Thursday, 01/15/2026",
"deliveredDate": "Wednesday, 01/14/2026",
"receivedBy": "JONES"
}
]
}
JSON

subtest 'UPStrack prefers deliveredDate over scheduledDeliveryDate' => sub {
@mock_responses = (
MockResponse->new( success => 1, content => $both_dates_json ),
);

my %result = UPStrack("1Z999AA10123456784");

is( $result{'Delivery Date'}, 'Wednesday, 01/14/2026',
'actual delivery date wins over scheduled date' );
};

done_testing();
Loading