Skip to content

New sounds#38154

Draft
elkoled wants to merge 25 commits into
masterfrom
sound
Draft

New sounds#38154
elkoled wants to merge 25 commits into
masterfrom
sound

Conversation

@elkoled

@elkoled elkoled commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

Soundd behavior change:
Looped sounds complete instead of being cut off when there is no pending alert.

@github-actions

github-actions Bot commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

Process replay diff report

Replays driving segments through this PR and compares the behavior to master.
Please review any changes carefully to ensure they are expected.

⚠️ 2 changed, 64 passed, 0 errors

Show changes

HYUNDAI - regenAA0FC4ED71E|2025-04-08--22-57-50--0 [selfdrived]

  selfdriveState.alertSound (21 diffs)
    frame 1693: none -> disengage
    frame 1694: none -> disengage
    frame 1695: none -> disengage
    frame 1696: none -> disengage
    frame 1697: none -> disengage
    frame 1698: none -> disengage
    frame 1699: none -> disengage
    frame 1700: none -> disengage
    frame 1701: none -> disengage
    frame 1702: none -> disengage
    (... 11 more)

  selfdriveState.deprecated.alertSound (21 diffs)
    frame 1693: disengage -> none
    frame 1694: disengage -> none
    frame 1695: disengage -> none
    frame 1696: disengage -> none
    frame 1697: disengage -> none
    frame 1698: disengage -> none
    frame 1699: disengage -> none
    frame 1700: disengage -> none
    frame 1701: disengage -> none
    frame 1702: disengage -> none
    (... 11 more)

TOYOTA - regen218A4DCFAA1|2025-04-08--22-57-51--0 [selfdrived]

  selfdriveState.alertSound (21 diffs)
    frame 4564: none -> engage
    frame 4565: none -> engage
    frame 4566: none -> engage
    frame 4567: none -> engage
    frame 4568: none -> engage
    frame 4569: none -> engage
    frame 4570: none -> engage
    frame 4571: none -> engage
    frame 4572: none -> engage
    frame 4573: none -> engage
    (... 11 more)

  selfdriveState.deprecated.alertSound (21 diffs)
    frame 4564: engage -> none
    frame 4565: engage -> none
    frame 4566: engage -> none
    frame 4567: engage -> none
    frame 4568: engage -> none
    frame 4569: engage -> none
    frame 4570: engage -> none
    frame 4571: engage -> none
    frame 4572: engage -> none
    frame 4573: engage -> none
    (... 11 more)

@github-actions

github-actions Bot commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

UI Preview

mici: Videos are identical! View Diff Report
big: Videos are identical! View Diff Report

Comment thread selfdrive/ui/soundd.py
@elkoled

elkoled commented Jun 10, 2026

Copy link
Copy Markdown
Contributor Author

process replay diff is expected due to alertSoundDEPRECATED change.

@elkoled elkoled marked this pull request as ready for review June 10, 2026 01:39
Comment thread cereal/log.capnp Outdated
Comment thread cereal/log.capnp Outdated
Comment thread cereal/log.capnp
alertSize @39 :SelfdriveState.AlertSize;
alertType @44 :Text;
alertSound2 @56 :Car.CarControl.HUDControl.AudibleAlert;
alertSound2 @56 :SelfdriveState.AudibleAlert;

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks like it will break backwards compatibility with old logs?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the schema is identical up to @Confirmation, tested with master log against this branch.

@elkoled elkoled marked this pull request as draft June 12, 2026 03:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants