Conversation
Contributor
Process replay diff reportReplays driving segments through this PR and compares the behavior to master. Show changes |
Contributor
UI Previewmici: Videos are identical! View Diff Report |
Contributor
Author
|
process replay diff is expected due to alertSoundDEPRECATED change. |
| alertSize @39 :SelfdriveState.AlertSize; | ||
| alertType @44 :Text; | ||
| alertSound2 @56 :Car.CarControl.HUDControl.AudibleAlert; | ||
| alertSound2 @56 :SelfdriveState.AudibleAlert; |
Contributor
There was a problem hiding this comment.
this looks like it will break backwards compatibility with old logs?
Contributor
Author
There was a problem hiding this comment.
the schema is identical up to @Confirmation, tested with master log against this branch.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Soundd behavior change:
Looped sounds complete instead of being cut off when there is no pending alert.