Skip to content

Omit escaping paths when copying IFS objects #2819

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sebjulliand merged 1 commit into from
Jul 30, 2025
Merged

Omit escaping paths when copying IFS objects #2819

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
47 changes: 23 additions & 24 deletions src/api/IBMiContent.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,21 +138,21 @@ export default class IBMiContent {

/**
* Download the content of a source member
*
* @param library
* @param sourceFile
* @param member
* @param localPath
*
* @param library
* @param sourceFile
* @param member
* @param localPath
*/
async downloadMemberContent(library: string, sourceFile: string, member: string, localPath?: string): Promise<string>;
/**
* @deprecated Will be removed in `v3.0.0`; use {@link IBMiContent.downloadMemberContent()} without the `asp` parameter instead.
*
* @param asp
* @param library
* @param sourceFile
* @param member
* @param localPath
*
* @param asp
* @param library
* @param sourceFile
* @param member
* @param localPath
*/
async downloadMemberContent(asp: string | undefined, library: string, sourceFile: string, member: string, localPath?: string): Promise<string>;
async downloadMemberContent(aspOrLibrary: string | undefined, libraryOrSourceFile: string, sourceFileOrMember: string, memberOrLocalPath?: string, localPath?: string): Promise<string> {
Expand Down Expand Up @@ -221,21 +221,21 @@ export default class IBMiContent {

/**
* Upload to a member
*
* @param library
* @param sourceFile
* @param member
* @param content
*
* @param library
* @param sourceFile
* @param member
* @param content
*/
async uploadMemberContent(library: string, sourceFile: string, member: string, content: string | Uint8Array): Promise<boolean>;

/**
* @deprecated Will be removed in `v3.0.0`; use {@link IBMiContent.uploadMemberContent()} without the `asp` parameter instead.
* @param asp
* @param library
* @param sourceFile
* @param member
* @param content
* @param asp
* @param library
* @param sourceFile
* @param member
* @param content
*/
async uploadMemberContent(asp: string | undefined, library: string, sourceFile: string, member: string, content: string | Uint8Array): Promise<boolean>;
async uploadMemberContent(aspOrLibrary: string | undefined, libraryOrFile: string, sourceFileOrMember: string, memberOrContent: string | Uint8Array, content?: string | Uint8Array): Promise<boolean> {
Expand Down Expand Up @@ -1153,9 +1153,8 @@ export default class IBMiContent {
*/
async copy(paths: string | string[], toPath: string): Promise<CommandResult> {
paths = Array.isArray(paths) ? paths : [paths];
toPath = Tools.escapePath(toPath);
const toPathIsDir = await this.isDirectory(toPath);
for (const path of paths.map(path => Tools.escapePath(path))) {
const toPathIsDir = await this.isDirectory(Tools.escapePath(toPath));
for (const path of paths) {
const result = await this.ibmi.runCommand({ command: `COPY OBJ('${path}') ${toPathIsDir ? 'TODIR(' : 'TOOBJ(' }'${toPath}') SUBTREE(*ALL) REPLACE(*YES)`, environment: "ile" });
if (result.code !== 0) {
return result;
Expand Down
Loading