Omit escaping paths when copying IFS objects - #2819
Merged
sebjulliand merged 1 commit intoJul 30, 2025
Merged
Conversation
chrjorgensen
temporarily deployed
to
testing_environment
July 29, 2025 18:37 — with
GitHub Actions
Inactive
sebjulliand
approved these changes
Jul 30, 2025
sebjulliand
left a comment
Member
There was a problem hiding this comment.
Looks good and works as advertised. Thanks @chrjorgensen !
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
The change to copying IFS objects using the
COPYcommand did not take into account, that the paths were being escaped for shell copy. This caused an error when copying files containing blanks:This PR will fix that by only escaping the path when testing the target for directory - which is still done in shell, by the
cdcommand.How to test this PR
Example:
Checklist