Skip to content

[ALCA-DB] [GCC16] cleanup for unused variables#50991

Merged
cmsbuild merged 1 commit into
cms-sw:masterfrom
smuzaffar:alca-db-gcc16-fix-unsed
May 20, 2026
Merged

[ALCA-DB] [GCC16] cleanup for unused variables#50991
cmsbuild merged 1 commit into
cms-sw:masterfrom
smuzaffar:alca-db-gcc16-fix-unsed

Conversation

@smuzaffar

Copy link
Copy Markdown
Contributor

Cleanup set but unused variables which are causing build errors for GCC16 IBs https://cmssdt.cern.ch/SDT/cgi-bin/showBuildLogs.py/el9_amd64_gcc16/www/tue/17.0-tue-23/CMSSW_17_0_X_2026-05-19-2300

@cmsbuild

cmsbuild commented May 20, 2026

Copy link
Copy Markdown
Contributor

cms-bot internal usage

@cmsbuild

Copy link
Copy Markdown
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-50991/49406

@cmsbuild

Copy link
Copy Markdown
Contributor

A new Pull Request was created by @smuzaffar for master.

It involves the following packages:

  • CalibCalorimetry/EcalLaserAnalyzer (alca)
  • CalibTracker/SiStripChannelGain (alca)
  • Calibration/HcalCalibAlgos (alca)
  • Calibration/IsolatedParticles (alca)

@Alejandro1400, @JanChyczynski, @arunhep, @atpathak, @cmsbuild, @perrotta can you please review it and eventually sign? Thanks.
@ReyerBand, @alesaggio, @argiro, @bsunanda, @echabert, @gbenelli, @mmusich, @rchatter, @robervalwalsh, @rsreds, @thomreis, @tocheng, @wang0jin, @yuanchao this is something you requested to watch as well.
@ftenchini, @mandrenguyen, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@smuzaffar

Copy link
Copy Markdown
Contributor Author

please test

@cmsbuild

Copy link
Copy Markdown
Contributor

+1

Size: This PR adds an extra 56KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-326717/53365/summary.html
COMMIT: b981e06
CMSSW: CMSSW_17_0_X_2026-05-19-2300/el8_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/50991/53365/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 1 lines from the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 6 differences found in the comparisons
  • DQMHistoTests: Total files compared: 53
  • DQMHistoTests: Total histograms compared: 4198477
  • DQMHistoTests: Total failures: 68
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 4198389
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 52 files compared)
  • Checked 227 log files, 197 edm output root files, 53 DQM output files
  • TriggerResults: no differences found

@perrotta

Copy link
Copy Markdown
Contributor

+alca

@cmsbuild

Copy link
Copy Markdown
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @mandrenguyen, @ftenchini (and backports should be raised in the release meeting by the corresponding L2)

@mandrenguyen

Copy link
Copy Markdown
Contributor

+1

@cmsbuild cmsbuild merged commit 9665ca8 into cms-sw:master May 20, 2026
10 checks passed
@smuzaffar smuzaffar deleted the alca-db-gcc16-fix-unsed branch May 27, 2026 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants