Move stored types in io_v1 namespace, reset class versions to 3#50968
Conversation
|
hold Until 20_0_X opens |
|
cms-bot internal usage |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-50968/49372
|
|
Pull request has been put on hold by @makortel |
|
A new Pull Request was created by @makortel for master. It involves the following packages:
@Alejandro1400, @BenjaminRS, @Dr15Jones, @JanChyczynski, @Martin-Grunewald, @Moanwar, @alja, @arunhep, @atpathak, @battibass, @civanch, @cmsbuild, @ctarricone, @emeschi, @ftorrresd, @gabrielmscampos, @jfernan2, @kpedro88, @lviliani, @makortel, @mandrenguyen, @mdhildreth, @mkirsano, @mmusich, @perrotta, @quinnanm, @rseidita, @sensrcn, @smorovic, @smuzaffar, @srimanob, @ssekmen, @theofil, @tvami can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
+dqm |
|
@cmsbuild, please test To refresh |
|
@cms-sw/fastsim-l2 @cms-sw/generators-l2 @cms-sw/hlt-l2 @cms-sw/l1-l2 @cms-sw/simulation-l2 @cms-sw/xpog-l2 Could review and sign, please? Thanks! |
|
+1 Size: This PR adds an extra 16KB to repository Comparison SummaryMax Memory Comparisons exceeding threshold@cms-sw/core-l2 , I found 19 workflow step(s) with memory usage exceeding the error threshold: Expand to see workflows ...
|
|
+1 |
|
DQM bin by bin comparisons did not show any physics differences (beyond the random differences related to #47071) |
|
@cmsbuild, please test To refresh |
|
+1 Size: This PR adds an extra 16KB to repository Comparison SummaryMax Memory Comparisons exceeding threshold@cms-sw/core-l2 , I found 19 workflow step(s) with memory usage exceeding the error threshold: Expand to see workflows ...
|
|
+hlt |
|
@cms-sw/generators-l2 @cms-sw/l1-l2 @cms-sw/xpog-l2 Could review and sign, please? Thanks! |
|
-1 Failed Tests: RelVals RelVals-INPUT Failed RelValsFailed RelVals-INPUT |
|
+1 Size: This PR adds an extra 16KB to repository Comparison SummaryMax Memory Comparisons exceeding threshold@cms-sw/core-l2 , I found 16 workflow step(s) with memory usage exceeding the error threshold: Expand to see workflows ...
|
|
@cmsbuild, please test To refresh |
|
@cms-sw/generators-l2 @cms-sw/l1-l2 @cms-sw/xpog-l2 Could you review and sign, please? Thanks! (we are getting close to the |
|
+1 Size: This PR adds an extra 16KB to repository Comparison SummaryMax Memory Comparisons exceeding threshold@cms-sw/core-l2 , I found 16 workflow step(s) with memory usage exceeding the error threshold: Expand to see workflows ...
|
|
Milestone for this pull request has been moved to CMSSW_20_0_X. Please open a backport if it should also go in to CMSSW_17_0_X. |
|
unhold
|
|
+1 |
PR description:
This PR integrates the data format changes prototyped and tested in the EVOLUTION_X branch to the
masterbranch for 20_0_X. Following the strategy agreed in ORP 2026-05-05, it is opened already now to allow it to be reviewed such that it could be merged quickly when the master branch moves to 20_0_X.This PR includes
io_v1namespace to allow schema evolution for complex cases that ROOT's schema evolution can not support (e.g. pointed-to container type of edm::Ref being changed)For more information please see the ORP 2026-05-05 presentation and the earlier talks linked there.
This PR is unusual in several ways:
git show -b b104b18evolutionlabel https://github.com/cms-sw/cmssw/pulls?q=is%3Apr+label%3Aevolution+is%3AclosedResolves cms-sw/framework-team#2227
PR validation:
None beyond the tests in the EVOLUTION_X IBs. Checked on CMSSW_17_0_X_2026-05-18-1100 that cherry-picking #50953, #50954, and this PR shows no difference wrt. CMSSW_17_0_EVOLUTION_X branch.