Skip to content

Add JSON for LST-seeded iteration (phase-2 offline)#20

Open
bdanzi wants to merge 1 commit into
cms-data:mainfrom
bdanzi:main
Open

Add JSON for LST-seeded iteration (phase-2 offline)#20
bdanzi wants to merge 1 commit into
cms-data:mainfrom
bdanzi:main

Conversation

@bdanzi

@bdanzi bdanzi commented Jun 6, 2026

Copy link
Copy Markdown

As stated in the title, this supports Phase-2 offline development and keeps it separate from the online Phase-2 HLT baseline.

@cmsbuild

cmsbuild commented Jun 6, 2026

Copy link
Copy Markdown
Contributor

A new Pull Request was created by @bdanzi for branch main.

@Moanwar, @akritkbehera, @cmsbuild, @iarspider, @jfernan2, @mandrenguyen, @raoatifshad, @smuzaffar, @srimanob can you please review it and eventually sign? Thanks.
@ftenchini, @mandrenguyen, @sextonkennedy you are the release manager for this.
cms-bot commands are listed here

@cmsbuild

cmsbuild commented Jun 6, 2026

Copy link
Copy Markdown
Contributor

cms-bot internal usage

@Moanwar

Moanwar commented Jun 6, 2026

Copy link
Copy Markdown

@bdanzi any workflows to test this PR with ?

@slava77

slava77 commented Jun 8, 2026

Copy link
Copy Markdown

@bdanzi any workflows to test this PR with ?

This will need a cmssw PR.
is it possible to merge this without that other PR?
We were discussing to have an internal review of that PR first, including the CI available with SegmentLinking/cmssw repo. But our CI is not set up to pick up a cms-data file. If it's possible to merge this data file first we'd have a more cleaner prepared PR for cms-sw/cmssw.

@Moanwar

Moanwar commented Jun 8, 2026

Copy link
Copy Markdown

Hi @slava77,

I don't mind merging the file, but for my understanding, isn't this file intended to replace the JSON file first presented here?

#19 (comment)

If so, then this file could be tested here:

https://github.com/trackreco/cmssw/blob/226447fa51865c3e1ec4fac4a52d2125be958e36/HLTrigger/Configuration/python/HLT_75e33/eventsetup/hltESPMkFit_cfi.py#L24

by simply changing the file name, right? Unless I am missing something.

If that's the case, would it be possible to open a draft PR to test the file first?

@bdanzi

bdanzi commented Jun 8, 2026

Copy link
Copy Markdown
Author

Hi @slava77,

I don't mind merging the file, but for my understanding, isn't this file intended to replace the JSON file first presented here?

#19 (comment)

If so, then this file could be tested here:

https://github.com/trackreco/cmssw/blob/226447fa51865c3e1ec4fac4a52d2125be958e36/HLTrigger/Configuration/python/HLT_75e33/eventsetup/hltESPMkFit_cfi.py#L24

by simply changing the file name, right? Unless I am missing something.

If that's the case, would it be possible to open a draft PR to test the file first?

This PR introduces the first JSON configuration that supports the combined LST + mkFit algorithms for offline development. At the moment, there is no equivalent JSON for this setup. It remains decoupled from HLT modules and sequences tests. As @slava77 mentioned, we plan to test it internally and make minor adjustments to the integrated JSON if needed.

FYI @mmasciov

@Moanwar

Moanwar commented Jun 8, 2026

Copy link
Copy Markdown

Hi @bdanzi , I see you already opened PR to test the offline JSON configuration for LST + mkFit algo , so lets test them together , thanks

@jfernan2

Copy link
Copy Markdown

+1
Based on tests with draft PR cms-sw/cmssw#51140

@smuzaffar

Copy link
Copy Markdown
Contributor

+externals

Only contains new data (json) file

@cmsbuild

Copy link
Copy Markdown
Contributor

This pull request is fully signed and it will be integrated in one of the next main IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @mandrenguyen, @sextonkennedy, @ftenchini (and backports should be raised in the release meeting by the corresponding L2)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants