Skip to content

[iOS] set up missing tab helpers for quickview when JSFeature is disabled #38689

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nuo-xu wants to merge 1 commit into
base: master
Choose a base branch
from
+14 −3
Open

[iOS] set up missing tab helpers for quickview when JSFeature is disabled #38689

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 14 additions & 3 deletions ios/brave-ios/Sources/Brave/Frontend/Browser/QuickView/QuickViewController.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,6 +116,17 @@ class QuickViewController: UIViewController {
tab.addObserver(toolbarViewModel)
tab.addObserver(self)
tab.browserData = TabBrowserData(tab: tab)
if FeatureList.kUseProfileWebViewConfiguration.enabled {
let braveShieldsHelper: BraveShieldsTabHelper = .init(
tab: tab,
braveShieldsSettings: BraveShieldsSettingsServiceFactory.get(profile: tab.profile)
)
tab.braveShieldsHelper = braveShieldsHelper
tab.addPolicyDecider(braveShieldsHelper)
tab.requestBlockingTabHelper = .init(tab: tab)
}
tab.cosmeticFilteringTabHelper = .init(tab: tab)
tab.protectionStats = .init(tab: tab)
tab.readerMode = .init(tab: tab, readerModeCache: ReaderModeScriptHandler.cache(for: tab))
tab.readerMode?.onStateChanged = { [weak self, weak tab] in
self?.toolbarViewModel.readerModeState = tab?.readerMode?.state ?? .unavailable
Expand Down Expand Up @@ -725,9 +736,9 @@ extension QuickViewController: TabDelegate {

extension QuickViewController: TabObserver {
func tabDidCreateWebView(_ tab: some TabState) {
if let detachedTabPrivacyHelper = DetachedTabPrivacyHelper(
tab: tab
) {
if !FeatureList.kUseProfileWebViewConfiguration.enabled,
let detachedTabPrivacyHelper = DetachedTabPrivacyHelper(tab: tab)
{
tab.detachedPrivacyHelper = detachedTabPrivacyHelper
}
}
Expand Down
Loading