Skip to content

[iOS] set up missing tab helpers for quickview when JSFeature is disabled - #38689

Open
nuo-xu wants to merge 1 commit into
masterfrom
quickview/missing-tab-helpers
Open

[iOS] set up missing tab helpers for quickview when JSFeature is disabled#38689
nuo-xu wants to merge 1 commit into
masterfrom
quickview/missing-tab-helpers

Conversation

@nuo-xu

@nuo-xu nuo-xu commented Jul 31, 2026

Copy link
Copy Markdown
Contributor

Add protectionStats and cosmeticFilteringTabHelper unconditionally, and wire braveShieldsHelper + requestBlockingTabHelper under kUseProfileWebViewConfiguration. Guard DetachedTabPrivacyHelper behind !kUseProfileWebViewConfiguration to avoid conflicts. Fixes adblock count always showing 0 in QuickView mode when kUseProfileWebViewConfiguration is enabled.

  • Resolves

@nuo-xu
nuo-xu requested review from a team and StephenHeaps July 31, 2026 19:15
@nuo-xu nuo-xu self-assigned this Jul 31, 2026
@nuo-xu nuo-xu added CI/skip-android Do not run CI builds for Android CI/skip-windows-x64 Do not run CI builds for Windows x64 CI/skip-macos-arm64 Do not run CI builds for macOS arm64 CI/skip-origin Do not run CI builds for Origin labels Jul 31, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI/skip-android Do not run CI builds for Android CI/skip-macos-arm64 Do not run CI builds for macOS arm64 CI/skip-origin Do not run CI builds for Origin CI/skip-windows-x64 Do not run CI builds for Windows x64

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants