Draft
Conversation
Update BEP-023 from master
…ication into visualize-changes
Visualize changes
Syncing Master from bids-standard/bids-specification:master with mnoergaard/bids-specification:bep-023;
… the wrong place.
Made some small changes to schema some relating to PET and some small edits to other imaging to account for some "compiling" errors encountered during the schema export/build. Meddling outside of PET was limited to - src/schema/rules/files/imaging.yaml - src/schema/rules/dataset_metadata.yaml The former had something to do with duplicate keys in the yaml and the later was made to allow for dataset description jsons at both /derivatives/dataset_description.json and /derivatives/pipline_name/dataset_description.json
…e-error Align's validator to bids-examples/petprep
Merging into master in prep for transfer over to github.com/bids-standard/bids-specification
for more information, see https://pre-commit.ci
#2301) Moving draft into bids-standard org and it's own bep branch Spec renders, yaml lints, but rules/logic need work. Moving this here makes setting up the CI and running this on bids-standard/bids-examples:bep023 a bit more straight forward. Additionally, hoping to increase visibility and garner some community/discussion ahead of community review. * ENH: add petref suffix to schema * ENH: create bep-023 schema json * ENH: add petref suffix to schema * ENH: add petref suffix to imaging.yaml * added make command to make this BEP a bit easier * Update Makefile * update .gitignore * added MC and started Smoothing checks * update selector for smoothing and registration * ENH: add transformation rules * ENH: add petref to enums * fixed check script updated sidecars * added tabular entries for pet derivatives * starting to render IRL * Align's validator to bids-examples/petprep Made some small changes to schema some relating to PET and some small edits to other imaging to account for some "compiling" errors encountered during the schema export/build. Meddling outside of PET was limited to - src/schema/rules/files/imaging.yaml - src/schema/rules/dataset_metadata.yaml The former had something to do with duplicate keys in the yaml and the later was made to allow for dataset description jsons at both /derivatives/dataset_description.json and /derivatives/pipline_name/dataset_description.json * remove data/ from tracked files * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * more cleanup * remove glob from dataset_description rule * move tabular rules to proper place * fix formatting errors, latin phrases, etc --------- Co-authored-by: Martin Norgaard <martin.noergaard@nru.dk> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
… adding selector to atlas rules
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a draft, comments welcome not required.