Open
Conversation
Contributor
|
You're going to add hemi for volumetric data? Or are you using the FS-NIfTI hack for surfaces? Either way, just use GIFTI. |
Contributor
|
I am quite certain the extension should be .mimap and not pet since the values are not PET values anymore (discussed many times in many different threads @mnoergaard |
Contributor
|
If we want to use mimap, we need to finish off bids-standard/bids-specification#2262. |
Contributor
|
I agree - we cannot push a PET atlas with the wrong extension |
Contributor
Author
We need to update the spec then as any suffix is allowed. I'd rather change the schema than try to meddle with the spec directly, but maybe that's just me. This PR works with these examples and complies with the spec, so it is possible to have both. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds PET atlas to examples, will fail validator for version v1.11.1, fix coming in minor release v1.11.2.