Skip to content

PBR Clearcoat: Avoid division by zero #25414

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alice-i-cecile merged 2 commits into from
Aug 18, 2026
Merged

PBR Clearcoat: Avoid division by zero #25414

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
10c59cd
avoid division by zero
EmbersArc Aug 14, 2026
5689ac5
Merge remote-tracking branch 'upstream' into clearcoat-division-fix
EmbersArc Aug 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion crates/bevy_pbr/src/render/pbr_lighting.wesl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -296,7 +296,8 @@ fn G_Smith(NdotV: f32, NdotL: f32, roughness: f32) -> f32 {
//
// https://google.github.io/filament/Filament.md.html#materialsystem/clearcoatmodel
fn V_Kelemen(LdotH: f32) -> f32 {
return 0.25 / (LdotH * LdotH);
let l_dot_h = max(LdotH, 0.0001);
return 0.25 / (l_dot_h * l_dot_h);
}

// Fresnel function
Expand Down