fix(gui): always show the release name on the tracker upload card#258
fix(gui): always show the release name on the tracker upload card#258maksii wants to merge 1 commit into
Conversation
The naming overrides were computed as a diff against the preview snapshot, but a preview round-trip echoes the applied overrides back into it, so the list emptied itself on every metadata refresh. The release name was gated behind that list being non-empty and disappeared with it, leaving the dry-run panel as the only place a name was visible. Report the overrides in effect, and show the prepared name until a dry run resolves the tracker name.
|
Warning Review limit reached
Next review available in: 50 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (3)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
The release name could vanish from the tracker upload card entirely, leaving the dry-run panel as the only place in the GUI where a name was visible.
Why it disappeared
namingOverrideswas computed as a diff between the override state and thepreview.ReleaseNameOverridessnapshot. But a preview round-trip echoes the applied overrides straight back into that snapshot, so as soon as the metadata was refreshed the two sides matched, every entry was filtered out, and the list emptied itself.The release name was rendered inside the block gated on
namingOverrides.length > 0, so it disappeared along with the list.Fix
Report the overrides in effect rather than the ones edited since the last preview — the snapshot is not a stable "before" to diff against, so the diff was never meaningful. An override is now listed when it holds a non-empty value.
The release name moves out of that block and onto the card unconditionally. It shows the dry-run-resolved upload name once one exists, and falls back to the prepared name before then, labelled so it is clear which one is on screen:
The overrides list keeps its own disclosure and now carries a count (
Naming overrides (3)), since it no longer has the release name sitting above it for context.Covered by a new case in
pages/tracker_upload/index.test.tsx.pnpm typecheck,pnpm lintandpnpm test:unit(204 tests) all pass.