refactor: ensure data as readonly when possible

src/util/getWorstHealthCheckStatus.ts

@@ -1,7 +1,7 @@
 import { HealthCheck, HealthCheckStatus } from '../services/topoCliSchema';
 
 export const getWorstHealthCheckStatus = (
-    healthChecks: HealthCheck[],
+    healthChecks: readonly HealthCheck[],
 ): HealthCheckStatus => {
     return healthChecks.reduce((acc: HealthCheckStatus, healthCheck) => {
         if (healthCheck.status === 'error') {

src/views/hostTreeView.test.ts

@@ -34,7 +34,7 @@ describe('HostTreeView', () => {
         expect(children[0].contextValue).toBe('Health');
     });
 
-    it('returns host health checks sorted by name below the Health group', async () => {
+    it('returns sorted host health checks without mutating the model', async () => {
         const model = new HostModel();
         model.setHealth(
             loaded({
@@ -79,6 +79,13 @@ describe('HostTreeView', () => {
                 description: 'missing',
             }),
         ]);
+        expect(model.health).toMatchObject({
+            data: {
+                host: {
+                    dependencies: [{ name: 'Zed' }, { name: 'Alpha' }],
+                },
+            },
+        });
     });
 
     it('returns an error item when host health cannot be loaded', async () => {

src/views/hostTreeView.ts

@@ -8,8 +8,10 @@ import { HostModel } from '../models/hostModel';
 import { DisposableCollector } from '../util/disposableCollector';
 import { loaded } from '../util/loadable';
 
-function sortHealthChecksByName(healthChecks: HealthCheck[]): HealthCheck[] {
-    return healthChecks.sort((a, b) =>
+function sortHealthChecksByName(
+    healthChecks: readonly HealthCheck[],
+): HealthCheck[] {
+    return healthChecks.toSorted((a, b) =>
         a.name.localeCompare(b.name, undefined, { sensitivity: 'base' }),
     );
 }

src/views/projectsTreeView.ts

@@ -14,7 +14,9 @@ import {
     ProcessingDomainTreeItem,
 } from './treeItems/processingDomainTreeItem';
 
-function syncProjectCountContext(projects: Loadable<ProjectMetadata[]>): void {
+function syncProjectCountContext(
+    projects: Loadable<readonly ProjectMetadata[]>,
+): void {
     const count =
         projects.status === 'loaded' ? projects.data.length : undefined;
     void vscode.commands.executeCommand(
@@ -35,7 +37,7 @@ function compareContainers(a: ContainerItem, b: ContainerItem): number {
 }
 
 function groupContainersByProcessingDomain(
-    containers: ContainerItem[],
+    containers: readonly ContainerItem[],
 ): ProcessingDomainTreeItem[] {
     const containersByDomain = new Map<string, ContainerItem[]>();
     for (const container of containers) {
@@ -48,7 +50,7 @@ function groupContainersByProcessingDomain(
 
     return [...containersByDomain.entries()]
         .map(([domain, containers]) => {
-            const sortedContainers = [...containers].sort(compareContainers);
+            const sortedContainers = containers.toSorted(compareContainers);
             return new ProcessingDomainTreeItem(domain, sortedContainers);
         })
         .sort(compareProcessingDomains);

src/views/targetTreeView.ts

@@ -94,7 +94,9 @@ function getSelectedTargetChildren(
     }
 }
 
-function syncTargetDataIssueContext(targets: Loadable<string[]>): void {
+function syncTargetDataIssueContext(
+    targets: Loadable<readonly string[]>,
+): void {
     void vscode.commands.executeCommand(
         'setContext',
         manifest.CONTEXT_TARGET_DATA_ISSUE,
@@ -199,7 +201,7 @@ export class TargetTreeView
         }
 
         if (element instanceof HealthCheckGroupTreeItem) {
-            const healthChecks = [...element.healthChecks].sort(compareByName);
+            const healthChecks = element.healthChecks.toSorted(compareByName);
             return healthChecks.map(
                 (healthCheck) => new HealthCheckTreeItem(loaded(healthCheck)),
             );

src/views/treeItems/healthCheckGroupTreeItem.ts

@@ -6,9 +6,9 @@ import { Loaded } from '../../util/loadable';
 import { hasFixCommand } from '../../util/issueFixes';
 
 export class HealthCheckGroupTreeItem extends vscode.TreeItem {
-    public readonly healthChecks: HealthCheck[];
+    public readonly healthChecks: readonly HealthCheck[];
 
-    constructor(healthChecks: Loaded<HealthCheck[]>) {
+    constructor(healthChecks: Loaded<readonly HealthCheck[]>) {
         super('Health', vscode.TreeItemCollapsibleState.Collapsed);
         this.contextValue = 'Health';
         if (healthChecks.data.some(hasFixCommand)) {

src/views/treeItems/processingDomainTreeItem.ts

@@ -21,7 +21,7 @@ export function compareProcessingDomains(
 export class ProcessingDomainTreeItem extends vscode.TreeItem {
     constructor(
         public readonly processingDomain: string,
-        public readonly containers?: ContainerItem[],
+        public readonly containers?: readonly ContainerItem[],
     ) {
         super(
             processingDomain,

src/views/treeItems/projectTreeItem.ts

@@ -4,7 +4,7 @@ import { Loadable } from '../../util/loadable';
 import { ContainerItem } from '../../util/types';
 
 function getCollapsibleState(
-    containers: Loadable<ContainerItem[]>,
+    containers: Loadable<readonly ContainerItem[]>,
 ): vscode.TreeItemCollapsibleState {
     if (containers.status === 'loaded') {
         return containers.data.length > 0
@@ -25,7 +25,7 @@ export class ProjectTreeItem extends vscode.TreeItem {
     constructor(
         public readonly project: ProjectMetadata,
         showWorkspaceName: boolean,
-        public readonly containers: Loadable<ContainerItem[]>,
+        public readonly containers: Loadable<readonly ContainerItem[]>,
     ) {
         super(project.name, getCollapsibleState(containers));
         this.composeFileUri = project.composeFileUri;

tsconfig.eslint.json

@@ -1,7 +1,7 @@
 {
     "extends": "./tsconfig.json",
     "compilerOptions": {
-        "lib": ["ES2022", "DOM"],
+        "lib": ["ES2023", "DOM"],
         "types": ["node", "vitest/globals"]
     },
     "include": ["**/*.ts"]

tsconfig.json

@@ -1,8 +1,8 @@
 {
     "compilerOptions": {
-        "target": "ES2022",
+        "target": "ES2023",
         "module": "commonjs",
-        "lib": ["ES2022"],
+        "lib": ["ES2023"],
         "types": ["node", "vitest/globals"],
         "sourceMap": true,
         "strict": true,