refactor: ensure data as readonly when possible - #382
Open
federicobozzini wants to merge 3 commits into
Open
Conversation
Signed-off-by: Federico Bozzini <federico.bozzini@arm.com>
awphi
approved these changes
Jul 27, 2026
awphi
left a comment
Contributor
There was a problem hiding this comment.
Looks sensible on its own but I wonder if we should make this even stricter and have the model return readonly values rather than claiming immutability for a handful of values halfway through the view layer.
Also think we should enforce this for objects too via Readonly (will need to write a recursive type to make it deep). Wondering if we could hoist all this up and just define loadables as, say
export type Loaded<T> = DeepReadonly<{ status: 'loaded'; data: T; loading: boolean }>;Because you should never mutate any part of a loadable after its created? I think that's a safe assertion to make?
Signed-off-by: Federico Bozzini <federico.bozzini@arm.com>
Collaborator
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Screenshots