Skip to content

fix(secret): Deduplicate based on rule ID and line range #11046

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
b40yd wants to merge 1 commit into
base: main
Choose a base branch
from
+7 −4
Open

fix(secret): Deduplicate based on rule ID and line range #11046

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions pkg/fanal/secret/scanner.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -820,12 +820,15 @@ func (s *Scanner) scanChunk(filePath string, content []byte, binary bool) types.
}

// deduplicateFindings removes duplicate secret findings that may occur at chunk boundaries
// or from multiple regex matches of the same rule on the same line.
func (s *Scanner) deduplicateFindings(findings []types.SecretFinding) []types.SecretFinding {
// Deduplicate based on rule ID and byte offset
// This accurately identifies the same secret across chunk boundaries
// Different secrets at the same offset are impossible, so this is safe
// Deduplicate based on rule ID and line range.
// Offset is intentionally excluded — same rule matching at different byte
// positions on the same line(s) produces identical code blocks and should
// be reported once. Cross-chunk overlap duplicates share the same adjusted
// StartLine/EndLine, so this also handles streaming dedup correctly.
return lo.UniqBy(findings, func(f types.SecretFinding) string {
return fmt.Sprintf("%s:%d-%d-%d", f.RuleID, f.StartLine, f.EndLine, f.Offset)
return fmt.Sprintf("%s:%d-%d", f.RuleID, f.StartLine, f.EndLine)
})
}

Expand Down