Skip to content

fix(secret): Deduplicate based on rule ID and line range - #11046

Open
b40yd wants to merge 1 commit into
aquasecurity:mainfrom
b40yd:main
Open

fix(secret): Deduplicate based on rule ID and line range#11046
b40yd wants to merge 1 commit into
aquasecurity:mainfrom
b40yd:main

Conversation

@b40yd

@b40yd b40yd commented Aug 5, 2026

Copy link
Copy Markdown

The same rule symfony-default-secret produced two SecretFinding instances on the same line 865. The deduplication key is RuleID:StartLine:EndLine:Offset. Since the two matches have different Offsets, they are not deduplicated. However, they are actually on the same line, and the code blocks are exactly identical, so users see duplicated output.

Checklist

  • I've read the guidelines for contributing to this repository.
  • I've followed the conventions in the PR title.
  • I've added tests that prove my fix is effective or that my feature works.
  • I've updated the documentation with the relevant information (if needed).
  • I've added usage information (if the PR introduces new options)
  • I've included a "before" and "after" example to the description (if the PR is a user interface change).

@CLAassistant

CLAassistant commented Aug 5, 2026

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@nikpivkin

Copy link
Copy Markdown
Contributor

Hi @b40yd !

Could you please share an example that reproduces the issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants