Extract DeletionVector logic from PuffinFile#3491
Open
ebyhr wants to merge 1 commit into
Open
Conversation
ebyhr
force-pushed
the
ebi/puffin-refactoring
branch
3 times, most recently
from
cf9a2ce to
374d25c
Compare
ebyhr
force-pushed
the
ebi/puffin-refactoring
branch
from
374d25c to
74e0d7b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
PuffinFile handles two tasks: format parsing (magic bytes, footer, blobs) and deletion vector domain logic (bitmap deserialization and PyArrow conversion).
This will become problematic when we introduce support for the NDV
apache-datasketches-theta-v1blob in the future.Are these changes tested?
Yes
Are there any user-facing changes?
Yes - PuffinFile class user needs to call DeletionVector.