[WIP]Support range-based reads for deletion vectors#3478
Open
KaiqiJinWow wants to merge 1 commit into
Open
Conversation
KaiqiJinWow
changed the title
KaiqiJinWow
force-pushed
the
fix-dv-content-range-read
branch
2 times, most recently
from
fdc8d3b to
859efdc
Compare
KaiqiJinWow
force-pushed
the
fix-dv-content-range-read
branch
from
859efdc to
118c561
Compare
ebyhr
reviewed
Jun 12, 2026
Comment on lines
1163
to
+1167
| elif data_file.file_format == FileFormat.PUFFIN: | ||
| with io.new_input(data_file.file_path).open() as fi: | ||
| content_offset = getattr(data_file, "content_offset", None) | ||
| content_size_in_bytes = getattr(data_file, "content_size_in_bytes", None) | ||
| if content_offset is not None or content_size_in_bytes is not None: |
Member
There was a problem hiding this comment.
If the file format is Puffin, these two fields are never None, right?
https://iceberg.apache.org/spec/#data-file-fields
The content_offset and content_size_in_bytes fields are used to reference a specific blob for direct access to a deletion vector. For deletion vectors, these values are required and must exactly match the offset and length stored in the Puffin footer for the deletion vector blob.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing
.venv/bin/python -m pytest -q tests/table/test_puffin.py tests/io/test_pyarrow.py::test_read_deletion_vector_blob_from_content_range tests/io/test_pyarrow.py::test_read_deletes