Skip to content

remove next_session_id, make ID 0-based#49

Closed
mgeier wants to merge 2 commits intonextfrom
matthias/session-id-minus-one
Closed

remove next_session_id, make ID 0-based#49
mgeier wants to merge 2 commits intonextfrom
matthias/session-id-minus-one

Conversation

@mgeier
Copy link
Copy Markdown
Contributor

@mgeier mgeier commented Mar 24, 2026

It looks like the session ID isn't used anyway, but maybe that's useful for debugging?

@mgeier
Copy link
Copy Markdown
Contributor Author

mgeier commented Mar 24, 2026

I just realized that the session ID is printed at the end, I somehow missed that before ...

@mgeier
Copy link
Copy Markdown
Contributor Author

mgeier commented Mar 24, 2026

I have restored the 1-based IDs in d5d77a1.

Not sure if this is worth the hassle, fell free to close without merging.

@mgeier mgeier mentioned this pull request Mar 24, 2026
@mgeier
Copy link
Copy Markdown
Contributor Author

mgeier commented Mar 26, 2026

With the latest changes to #47, this is now obsolete.

@mgeier mgeier closed this Mar 26, 2026
@mgeier mgeier deleted the matthias/session-id-minus-one branch March 26, 2026 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant