add async processor

[steckes]

No description provided.

[mgeier]

Clippy suggested this:

Suggested change

	print!("\n");
	println!();

[steckes]

I wonder why clippy does not complain here in CI and also not locally on my machine 🤔

[mgeier]

It was shown in my editor. On the command line it seems to only be shown when using

cargo clippy --all-targets --all-features

It looks like by default tests/examples/benchmarks are not included?

We should probably change our CI settings to something like

cargo clippy --all-targets --all-features -- -D warnings

[Fl1tzi]

I will have a closer look tomorrow.

[Fl1tzi]

I'm not sure if cloning the ProcessingConfig is a needed step here. I would assume that we could just accept an owned ProcessorConfig and implement Copy on the ProcessorConfig.

I haven't tried but #[derive(Copy)] should just work because all the types inside the ProcessorConfig implement Copy.

Suggested change

	pub async fn initialize(&self, config: &ProcessorConfig) -> Result<(), AicError> {
	let inner = Arc::clone(&self.inner);
	let config = config.clone();
	pub async fn initialize(&self, config: ProcessorConfig) -> Result<(), AicError> {
	let inner = Arc::clone(&self.inner);

[steckes]

That is correct, but I like to have the function similar to the non-async processor.
And in the end copying it outside results in the same as cloning it inside.
But it is a bit more beautiful, I agree.

[steckes]

@mgeier any preference here? Leave the interface the same in both or change it here to by-value instead of by-reference?

[mgeier]

In general, I think I would prefer the explicit clone() and passing it by reference.

The ProcessorConfig is very small, so implicit copying might be fine for now, but if the config grows over time I think it's better to make cloning explicit.

And another thing: I'm not sure if that's happening in reality, but if we have a mutable ProcessorConfig, we might inadvertently make copies of it and then make changes to different instances, leading to confusion ...

[mgeier]

#51 suggests a way to pass the config by reference without copying (but with using unsafe).

[mgeier]

As another data point, there's currently an open PR at cpal which suggests adding a DuplexStreamConfig which is Copy:

https://github.com/RustAudio/cpal/pull/1096/changes#diff-0a18ac1c64e2f0e86fe34809aef79ded16e15570385203969fb67e00dd8940cfR30-R36

Here is a comment regarding by value vs. by reference: RustAudio/cpal#1096 (review).

I think my argument would be the same, and I would advise against Copy.

[Fl1tzi]

I think ideally the model downloading and loading should also be async as in a full async setup, you would need to spawn a blocking task here again.

aic-sdk-rs/src/download/mod.rs

Lines 35 to 40 in d9a4d58

	/// Downloads a model file compatible with the provided model version.
	///
	/// The function fetches the model manifest, checks whether the requested model
	/// exists in a version compatible with the given `model_version`, and downloads
	/// the model file into the provided directory.
	pub fn download<P: AsRef<Path>>(

aic-sdk-rs/src/model.rs

Line 86 in d9a4d58

pub fn from_file<P: AsRef<Path>>(path: P) -> Result<Model<'static>, AicError> {