Skip to content

Fix panic when animation_fps is set to 0.0 #319

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
corpooo wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix panic when animation_fps is set to 0.0 #319

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions src/actor/reactor/animation.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,13 @@ pub struct Animation<'a> {

impl<'a> Animation<'a> {
pub fn new(fps: f64, duration: f64, _: AnimationEasing) -> Self {
// When fps is 0 (or negative), use the display's native refresh rate.
// Fall back to 60 Hz if the rate cannot be determined.
let fps = if fps > 0.0 {
fps
} else {
crate::sys::display_link::get_display_refresh_rate().unwrap_or(60.0)
};
let interval = Duration::from_secs_f64(1.0 / fps);
// let now = unsafe { CFAbsoluteTimeGetCurrent() };
let now = Instant::now();
Expand Down