Fix panic when animation_fps is set to 0.0#319
Open
corpooo wants to merge 1 commit intoacsandmann:mainfrom
Open
Fix panic when animation_fps is set to 0.0#319corpooo wants to merge 1 commit intoacsandmann:mainfrom
corpooo wants to merge 1 commit intoacsandmann:mainfrom
Conversation
`Animation::new` computes `Duration::from_secs_f64(1.0 / fps)`. When fps is 0.0 this produces infinity, which panics inside the standard library's Duration conversion. Use the display's native refresh rate (via `get_display_refresh_rate()`) when fps is 0.0, as originally intended by the config comment. Falls back to 60 Hz if the rate cannot be determined. Fixes acsandmann#316 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
animation_fps = 0.0without panickingWhy
Animation::newcurrently computes1.0 / fpsdirectly. Whenfpsis0.0, that produces infinity and panics duringDuration::from_secs_f64(...).The config comment already implies that
0.0should mean "use the display refresh rate", so this makes the implementation match the existing configuration contract.Verification
cargo build --profile release-fast --bin riftcargo test animation -- --nocapture