fix(ci): ignore stale and resolved Codex inline findings by Komzpa · Pull Request #981 · Soju06/codex-lb

Komzpa · 2026-06-11T06:20:09Z

Summary

classify inline Codex review comments by original_commit_id instead of trusting a rebased commit_id alone
filter unresolved Codex review threads with the same current-head/original-commit evidence rule, so stale rebased threads do not keep 🤖 codex: needs work
ignore resolved or outdated inline Codex findings when computing current-head review state
classify duplicate check-run names by the latest run start/creation time, so superseded failed or cancelled runs do not override a newer rerun on the same head
add OpenSpec coverage and regression tests for stale rebased comments, resolved inline findings, unresolved inline findings, and duplicate check-run recency

Absorbs #1002.

Tests

uv run pytest tests/unit/test_sync_codex_ok_labels.py
uv run ruff format --check .github/scripts/sync_codex_ok_labels.py tests/unit/test_sync_codex_ok_labels.py
uv run ruff check .github/scripts/sync_codex_ok_labels.py tests/unit/test_sync_codex_ok_labels.py
uv run ty check .github/scripts/sync_codex_ok_labels.py tests/unit/test_sync_codex_ok_labels.py
uv run openspec validate fix-codex-label-current-head-evidence --strict
uv run openspec validate ignore-resolved-codex-inline-findings --strict
uv run openspec validate --specs
git diff --check origin/main...HEAD

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 3b9708a18c

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Soju06 · 2026-06-11T06:31:06Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 027cf0cb3b

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Soju06 · 2026-06-11T06:42:43Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: c8dfb9571d

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Soju06 · 2026-06-11T06:56:49Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 1b590ae479

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Soju06 · 2026-06-11T07:12:58Z

@codex review

chatgpt-codex-connector · 2026-06-11T07:15:43Z

Codex Review: Didn't find any major issues. What shall we delve into next?

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Komzpa · 2026-06-14T19:39:59Z

@codex review

chatgpt-codex-connector · 2026-06-14T19:44:34Z

Codex Review: Didn't find any major issues. Nice work!

Reviewed commit: d71cb6480b

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Soju06 · 2026-06-15T23:39:38Z

@codex review

Komzpa · 2026-06-15T23:45:01Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 706eff12fc

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Soju06 · 2026-06-15T23:59:54Z

@codex review

chatgpt-codex-connector

💡 Codex Review

codex-lb/.github/scripts/sync_codex_ok_labels.py

Line 1008 in 6e24755

trigger_codex_review = (

Suppress review requests when findings are unresolved

When a reanchored Codex inline finding is still unresolved on the current head but its original review/comment timestamp predates that head, the new thread scan sets unresolved_finding_urls and wants_needs_work_label, while the timeline scan can still report review_state == "none" and has_codex_news == False. Because this trigger ignores unresolved_finding_urls, the scheduled/all-open run can post a redundant @codex review on a PR that is already blocked by an active current-head finding; add that guard here so needs-work evidence does not also request a fresh review.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector Bot reviewed Jun 11, 2026

View reviewed changes

Comment thread .github/scripts/sync_codex_ok_labels.py Outdated

Soju06 added the 🤖 codex: needs work [@codex review] raised an issue label Jun 11, 2026

Komzpa force-pushed the fix/codex-label-original-commit branch from 3b9708a to 027cf0c Compare June 11, 2026 06:25

Soju06 removed the 🤖 codex: needs work [@codex review] raised an issue label Jun 11, 2026

chatgpt-codex-connector Bot reviewed Jun 11, 2026

View reviewed changes

Comment thread .github/scripts/sync_codex_ok_labels.py Outdated

Soju06 added the 🤖 codex: needs work [@codex review] raised an issue label Jun 11, 2026

Komzpa force-pushed the fix/codex-label-original-commit branch from 027cf0c to c8dfb95 Compare June 11, 2026 06:36

Soju06 removed the 🤖 codex: needs work [@codex review] raised an issue label Jun 11, 2026

chatgpt-codex-connector Bot reviewed Jun 11, 2026

View reviewed changes

Comment thread .github/scripts/sync_codex_ok_labels.py

Soju06 added the 🤖 codex: needs work [@codex review] raised an issue label Jun 11, 2026

Komzpa force-pushed the fix/codex-label-original-commit branch from c8dfb95 to 1b590ae Compare June 11, 2026 06:51

Soju06 removed the 🤖 codex: needs work [@codex review] raised an issue label Jun 11, 2026

chatgpt-codex-connector Bot reviewed Jun 11, 2026

View reviewed changes

Comment thread .github/scripts/sync_codex_ok_labels.py Outdated

Soju06 added the 🤖 codex: needs work [@codex review] raised an issue label Jun 11, 2026

Komzpa force-pushed the fix/codex-label-original-commit branch from 1b590ae to 66dc6b8 Compare June 11, 2026 07:05

Komzpa removed the 🤖 codex: needs work [@codex review] raised an issue label Jun 11, 2026

Komzpa force-pushed the fix/codex-label-original-commit branch from 66dc6b8 to cac584a Compare June 11, 2026 07:06

Soju06 added the 🤖 codex: needs work [@codex review] raised an issue label Jun 11, 2026

Komzpa removed the 🤖 codex: needs work [@codex review] raised an issue label Jun 11, 2026

Soju06 added the 🤖 codex: needs work [@codex review] raised an issue label Jun 11, 2026

Komzpa removed the 🤖 codex: needs work [@codex review] raised an issue label Jun 11, 2026

Soju06 added the 🤖 codex: needs work [@codex review] raised an issue label Jun 11, 2026

Komzpa added 🤖 codex: ok [@codex review] says no issues found. and removed 🤖 codex: needs work [@codex review] raised an issue labels Jun 11, 2026

Soju06 removed the 🤖 codex: ok [@codex review] says no issues found. label Jun 11, 2026

Komzpa added the 🤖 codex: ok [@codex review] says no issues found. label Jun 11, 2026

Soju06 removed the 🤖 codex: ok [@codex review] says no issues found. label Jun 12, 2026

Komzpa added 4 commits June 14, 2026 23:27

fix(ci): ignore stale rebased codex inline comments

e8c1d68

fix(ci): ignore superseded duplicate check runs

c91b513

docs(openspec): document codex label evidence

681bfca

fix(ci): ignore resolved Codex inline findings

d71cb64

Komzpa force-pushed the fix/codex-label-original-commit branch from f313709 to d71cb64 Compare June 14, 2026 19:31

Komzpa changed the title ~~fix(ci): ignore stale rebased Codex inline comments~~ fix(ci): ignore stale and resolved Codex inline findings Jun 14, 2026

Komzpa mentioned this pull request Jun 14, 2026

fix(ci): ignore resolved Codex inline findings #1002

Closed

17 tasks

Komzpa mentioned this pull request Jun 15, 2026

fix(ci): ignore resolved Codex inline findings #1007

Closed

Komzpa added the 🤖 codex: ok [@codex review] says no issues found. label Jun 15, 2026

Soju06 removed the 🤖 codex: ok [@codex review] says no issues found. label Jun 15, 2026

Komzpa added the 🤖 codex: ok [@codex review] says no issues found. label Jun 15, 2026

Soju06 removed the 🤖 codex: ok [@codex review] says no issues found. label Jun 15, 2026

Komzpa added the 🤖 codex: ok [@codex review] says no issues found. label Jun 15, 2026

Soju06 removed the 🤖 codex: ok [@codex review] says no issues found. label Jun 15, 2026

Komzpa added the 🤖 codex: ok [@codex review] says no issues found. label Jun 15, 2026

Soju06 removed the 🤖 codex: ok [@codex review] says no issues found. label Jun 15, 2026

Komzpa added the 🤖 codex: ok [@codex review] says no issues found. label Jun 15, 2026

This was referenced Jun 15, 2026

feat(proxy): repair account-bound egress routing #875

Open

Tested live aggregate stack and suggested merge order #554

Closed

fix(ci): keep current commit Codex evidence

706eff1

chatgpt-codex-connector Bot reviewed Jun 15, 2026

View reviewed changes

Comment thread .github/scripts/sync_codex_ok_labels.py

ci: resync codex labels after thread resolution

6e24755

chatgpt-codex-connector Bot reviewed Jun 16, 2026

View reviewed changes

Conversation

Komzpa commented Jun 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Tests

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Soju06 commented Jun 11, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Soju06 commented Jun 11, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Soju06 commented Jun 11, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Soju06 commented Jun 11, 2026

Uh oh!

chatgpt-codex-connector Bot commented Jun 11, 2026

Uh oh!

Komzpa commented Jun 14, 2026

Uh oh!

chatgpt-codex-connector Bot commented Jun 14, 2026

Uh oh!

Soju06 commented Jun 15, 2026

Uh oh!

Komzpa commented Jun 15, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Soju06 commented Jun 15, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Komzpa commented Jun 11, 2026 •

edited

Loading